Moves WorkspaceEventHandler to ash/common

Moves WorkspaceEventHandler to ash/common

And wires up appropriately.

BUG=624173
TEST=covered by tests
R=jamescook@chromium.org

Committed: https://crrev.com/06ef3e319e3d9bd68798044b19199c3322b4beb5
Cr-Commit-Position: refs/heads/master@{#415302}

[sky, 2016-08-26 17:58:47]

Tests forthcoming (this isn't properly wired up yet, so tests would fail
anyway).

[sky, 2016-08-26 18:00:19]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 18:01:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-08-26 19:07:16]

LGTM

https://codereview.chromium.org/2285703003/diff/40001/ash/common/wm/workspace...
File ash/common/wm/workspace/workspace_event_handler.h (right):

https://codereview.chromium.org/2285703003/diff/40001/ash/common/wm/workspace...
ash/common/wm/workspace/workspace_event_handler.h:25: class ASH_EXPORT
WorkspaceEventHandler {
Can you add a class comment?

https://codereview.chromium.org/2285703003/diff/40001/ash/common/wm_shell.h
File ash/common/wm_shell.h (right):

https://codereview.chromium.org/2285703003/diff/40001/ash/common/wm_shell.h#n...
ash/common/wm_shell.h:274: // This may return null.
In tests? In this CL it's non-null for both aura and mus.

https://codereview.chromium.org/2285703003/diff/40001/ash/mus/bridge/workspac...
File ash/mus/bridge/workspace_event_handler_mus.h (right):

https://codereview.chromium.org/2285703003/diff/40001/ash/mus/bridge/workspac...
ash/mus/bridge/workspace_event_handler_mus.h:18: class WorkspaceEventHandlerMus
: public ash::WorkspaceEventHandler {
nit: no ash::

[commit-bot: I haz the power, 2016-08-26 19:11:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 19:11:29]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[sky, 2016-08-26 20:19:01]

The CQ bit was checked by sky@chromium.org

[sky, 2016-08-26 20:19:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2285703003/#ps60001
(title: "feedback")

[sky, 2016-08-26 20:19:16]

https://codereview.chromium.org/2285703003/diff/40001/ash/common/wm/workspace...
File ash/common/wm/workspace/workspace_event_handler.h (right):

https://codereview.chromium.org/2285703003/diff/40001/ash/common/wm/workspace...
ash/common/wm/workspace/workspace_event_handler.h:25: class ASH_EXPORT
WorkspaceEventHandler {
On 2016/08/26 19:07:16, James Cook wrote:
> Can you add a class comment?

Done.

https://codereview.chromium.org/2285703003/diff/40001/ash/common/wm_shell.h
File ash/common/wm_shell.h (right):

https://codereview.chromium.org/2285703003/diff/40001/ash/common/wm_shell.h#n...
ash/common/wm_shell.h:274: // This may return null.
On 2016/08/26 19:07:16, James Cook wrote:
> In tests? In this CL it's non-null for both aura and mus.

I'm going to remove the comment now that it always returns non-null.

https://codereview.chromium.org/2285703003/diff/40001/ash/mus/bridge/workspac...
File ash/mus/bridge/workspace_event_handler_mus.h (right):

https://codereview.chromium.org/2285703003/diff/40001/ash/mus/bridge/workspac...
ash/mus/bridge/workspace_event_handler_mus.h:18: class WorkspaceEventHandlerMus
: public ash::WorkspaceEventHandler {
On 2016/08/26 19:07:16, James Cook wrote:
> nit: no ash::

Done.

[commit-bot: I haz the power, 2016-08-26 20:19:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 21:41:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 21:41:51]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[sky, 2016-08-29 15:53:17]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2016-08-29 15:54:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-29 16:49:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-29 16:49:13]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[sky, 2016-08-29 16:53:25]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2016-08-29 16:57:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2016-08-30 03:17:45]

The CQ bit was unchecked by sky@chromium.org

[sky, 2016-08-30 03:17:56]

The CQ bit was checked by sky@chromium.org

[sky, 2016-08-30 03:30:55]

The CQ bit was checked by sky@chromium.org

[sky, 2016-08-30 03:30:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2285703003/#ps80001
(title: "merge 2 trunk")

[sky, 2016-08-30 13:24:13]

The CQ bit was unchecked by sky@chromium.org

[sky, 2016-08-30 13:24:21]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2016-08-30 13:24:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 15:40:10]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-08-30 15:43:47]

Description was changed from

==========
Moves WorkspaceEventHandler to ash/common

And wires up appropriately.

BUG=624173
TEST=covered by tests
R=jamescook@chromium.org
==========

to

==========
Moves WorkspaceEventHandler to ash/common

And wires up appropriately.

BUG=624173
TEST=covered by tests
R=jamescook@chromium.org

Committed: https://crrev.com/06ef3e319e3d9bd68798044b19199c3322b4beb5
Cr-Commit-Position: refs/heads/master@{#415302}
==========

[commit-bot: I haz the power, 2016-08-30 15:43:48]

Patchset 5 (id:??) landed as
https://crrev.com/06ef3e319e3d9bd68798044b19199c3322b4beb5
Cr-Commit-Position: refs/heads/master@{#415302}