Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 2285703002: MIPS: Use neg instruction in r6 (Closed)

Created:
4 years, 3 months ago by miran.karic
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Use neg instruction in r6 Floating point negate instructions are still present in release 6, only one format of neg is removed, NEG.PS. Others formats can be used and in r6 they also change the sign of NaN-like operands as well. This makes r6 generated code simpler for Neg_d and Neg_s macroassembler functions. BUG= Committed: https://crrev.com/c37f6f02ed7046fd5492776e372d30f4a08afd0c Cr-Commit-Position: refs/heads/master@{#38943}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -35 lines) Patch
M src/crankshaft/mips/lithium-codegen-mips.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 4 chunks +6 lines, -19 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 3 chunks +8 lines, -16 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
miran.karic
PTAL
4 years, 3 months ago (2016-08-26 11:58:45 UTC) #2
balazs.kilvady
lgtm, I like it :)
4 years, 3 months ago (2016-08-26 12:18:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2285703002/1
4 years, 3 months ago (2016-08-26 12:26:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-26 12:49:35 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 12:49:55 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c37f6f02ed7046fd5492776e372d30f4a08afd0c
Cr-Commit-Position: refs/heads/master@{#38943}

Powered by Google App Engine
This is Rietveld 408576698