Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 22857004: Merged r16128, r16135, r16136 into trunk branch. (Closed)

Created:
7 years, 4 months ago by danno
Modified:
7 years, 4 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Merged r16128, r16135, r16136 into trunk branch. Fix smi-based math floor. Allow HPhis to have an invalid merge index. Make sure polymorphic element access creates non-replaying phis. BUG=chromium:270268, v8:2815, v8:2815 R=jkummerow@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16155

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -84 lines) Patch
M src/arm/lithium-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/code-stubs.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/hydrogen.h View 8 chunks +25 lines, -29 lines 0 comments Download
M src/hydrogen.cc View 12 chunks +23 lines, -18 lines 0 comments Download
M src/hydrogen-dce.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/hydrogen-instructions.h View 6 chunks +26 lines, -3 lines 0 comments Download
M src/hydrogen-instructions.cc View 2 chunks +14 lines, -1 line 0 comments Download
M src/hydrogen-osr.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/lithium-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/regress/regress-smi-math-floor-round.js View 1 chunk +30 lines, -24 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
danno
7 years, 4 months ago (2013-08-12 16:46:52 UTC) #1
Jakob Kummerow
lgtm
7 years, 4 months ago (2013-08-12 16:49:55 UTC) #2
danno
7 years, 4 months ago (2013-08-12 16:58:09 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16155 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698