bluetooth: Added script for converting the Web Bluetooth blacklist.

bluetooth: Added script for converting the Web Bluetooth blacklist.

BUG=570121
Committed: https://crrev.com/a92816b18e7fd1d1bd90bf98a11a76143d1d2ca0
Cr-Commit-Position: refs/heads/master@{#415594}

[perja, 2016-08-26 08:51:45]

The CQ bit was checked by perja@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 08:51:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[perja, 2016-08-26 08:54:15]

Description was changed from

==========
bluetooth: Added script for converting the Web Bluetooth blacklist.

BUG=570121
==========

to

==========
bluetooth: Added script for converting the Web Bluetooth blacklist.

BUG=570121
==========

[perja, 2016-08-26 08:54:15]

perja@opera.com changed reviewers:
+ scheib@chromium.org

[perja, 2016-08-26 08:57:46]

@scheib: please take a look.

[commit-bot: I haz the power, 2016-08-26 09:28:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 09:28:12]

Dry run: This issue passed the CQ dry run.

[scheib, 2016-08-29 01:14:47]

LGTM

https://codereview.chromium.org/2285663002/diff/1/tools/webbt/compact_blackli...
File tools/webbt/compact_blacklist.py (right):

https://codereview.chromium.org/2285663002/diff/1/tools/webbt/compact_blackli...
tools/webbt/compact_blacklist.py:1: #!/usr/bin/env python
Let's place this file in tools/web_bluetooth/

https://codereview.chromium.org/2285663002/diff/1/tools/webbt/compact_blackli...
tools/webbt/compact_blacklist.py:56: # Note: this function shortens all UUIDs
that uses the Bluetooth base
s/uses/use/

[perja, 2016-08-29 07:30:26]

perja@opera.com changed reviewers:
+ scottmg@chromium.org

[perja, 2016-08-29 07:30:27]

scottmg: OWNERS review for new web_bluetooth folder in tools/.

[scottmg, 2016-08-29 15:34:03]

Mostly optional nits, other than:

Please add an OWNERS file to tools/web_bluetooth/OWNERS with at least two people
in it. With that lgtm.

https://codereview.chromium.org/2285663002/diff/20001/tools/web_bluetooth/com...
File tools/web_bluetooth/compact_blacklist.py (right):

https://codereview.chromium.org/2285663002/diff/20001/tools/web_bluetooth/com...
tools/web_bluetooth/compact_blacklist.py:2: # Copyright (c) 2016 The Chromium
Authors. All rights reserved.
no (c)

https://codereview.chromium.org/2285663002/diff/20001/tools/web_bluetooth/com...
tools/web_bluetooth/compact_blacklist.py:21: blacklist =
collections.OrderedDict()
I would make this g_blacklist, or BLACKLIST, or better, make it a local in the
try block of main() and pass it into process()

https://codereview.chromium.org/2285663002/diff/20001/tools/web_bluetooth/com...
tools/web_bluetooth/compact_blacklist.py:28: pass
2-space indent in Chromium still afaik:
https://www.chromium.org/chromium-os/python-style-guidelines.

https://codereview.chromium.org/2285663002/diff/20001/tools/web_bluetooth/com...
tools/web_bluetooth/compact_blacklist.py:43: def valid_uuid(uuid):
Functions should be UpperCase-style.

https://codereview.chromium.org/2285663002/diff/20001/tools/web_bluetooth/com...
tools/web_bluetooth/compact_blacklist.py:56: # Note: this function shortens all
UUIDs that use the Bluetooth base
Make this a """ docstring instead of a block comment before the function.

https://codereview.chromium.org/2285663002/diff/20001/tools/web_bluetooth/com...
tools/web_bluetooth/compact_blacklist.py:57: # UUID even thought the
specification states that only an assigned
"thought" -> "though"

https://codereview.chromium.org/2285663002/diff/20001/tools/web_bluetooth/com...
tools/web_bluetooth/compact_blacklist.py:93: sys.exit('Usage: %s
<gatt_blacklist.txt>' % sys.argv[0])
print and return 1 here

https://codereview.chromium.org/2285663002/diff/20001/tools/web_bluetooth/com...
tools/web_bluetooth/compact_blacklist.py:99: print(','.join('%s:%s' % (uuid,
blacklist[uuid]) for uuid in blacklist))
return 0 after here

https://codereview.chromium.org/2285663002/diff/20001/tools/web_bluetooth/com...
tools/web_bluetooth/compact_blacklist.py:101: sys.exit('Failed to compact
blacklist. %s' % e)
and here

https://codereview.chromium.org/2285663002/diff/20001/tools/web_bluetooth/com...
tools/web_bluetooth/compact_blacklist.py:105: main()
sys.exit(main()) here

[perja, 2016-08-31 08:49:57]

The CQ bit was checked by perja@opera.com

[perja, 2016-08-31 08:49:57]

The patchset sent to the CQ was uploaded after l-g-t-m from scheib@chromium.org,
scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/2285663002/#ps40001
(title: "Fixed nits and added OWNERS file.")

[commit-bot: I haz the power, 2016-08-31 08:50:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 09:43:17]

Description was changed from

==========
bluetooth: Added script for converting the Web Bluetooth blacklist.

BUG=570121
==========

to

==========
bluetooth: Added script for converting the Web Bluetooth blacklist.

BUG=570121
==========

[commit-bot: I haz the power, 2016-08-31 09:43:17]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-31 09:46:47]

Description was changed from

==========
bluetooth: Added script for converting the Web Bluetooth blacklist.

BUG=570121
==========

to

==========
bluetooth: Added script for converting the Web Bluetooth blacklist.

BUG=570121

Committed: https://crrev.com/a92816b18e7fd1d1bd90bf98a11a76143d1d2ca0
Cr-Commit-Position: refs/heads/master@{#415594}
==========

[commit-bot: I haz the power, 2016-08-31 09:46:48]

Patchset 3 (id:??) landed as
https://crrev.com/a92816b18e7fd1d1bd90bf98a11a76143d1d2ca0
Cr-Commit-Position: refs/heads/master@{#415594}