src/wasm/wasm-interpreter.cc - Issue 2285643002: [wasm] Validate the alignment of load and store instructions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/wasm/wasm-interpreter.cc

Issue 2285643002: [wasm] Validate the alignment of load and store instructions. (Closed)

Patch Set: Add alignment and maximum alignment information to the error message. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/wasm/wasm-interpreter.cc

diff --git a/src/wasm/wasm-interpreter.cc b/src/wasm/wasm-interpreter.cc

index 7e3127dd533220342e6ffed20725768558bec5f1..17ca6111e3a5e947570491f32a4102a5d7383440 100644

--- a/src/wasm/wasm-interpreter.cc

+++ b/src/wasm/wasm-interpreter.cc

@@ -1444,7 +1444,7 @@ class ThreadImpl : public WasmInterpreter::Thread {

#define LOAD_CASE(name, ctype, mtype) \

case kExpr##name: { \

- MemoryAccessOperand operand(&decoder, code->at(pc)); \

+ MemoryAccessOperand operand(&decoder, code->at(pc), sizeof(ctype)); \

uint32_t index = Pop().to<uint32_t>(); \

size_t effective_mem_size = instance()->mem_size - sizeof(mtype); \

if (operand.offset > effective_mem_size || \

@@ -1476,7 +1476,7 @@ class ThreadImpl : public WasmInterpreter::Thread {

#define STORE_CASE(name, ctype, mtype) \

case kExpr##name: { \

- MemoryAccessOperand operand(&decoder, code->at(pc)); \

+ MemoryAccessOperand operand(&decoder, code->at(pc), sizeof(ctype)); \

WasmVal val = Pop(); \

uint32_t index = Pop().to<uint32_t>(); \

size_t effective_mem_size = instance()->mem_size - sizeof(mtype); \

« no previous file with comments | « src/wasm/ast-decoder.cc ('k') | test/unittests/wasm/ast-decoder-unittest.cc » ('j') | no next file with comments »