[wasm] Validate the alignment of load and store instructions.

[wasm] Validate the alignment of load and store instructions.

According to the WebAssembly specification the alignment of load and
store instructions has to be less or equal to natural alignment.

R=titzer@chromium.org

Committed: https://crrev.com/6a892bb45111bf5f5dfd678e9995eb3957898136
Cr-Commit-Position: refs/heads/master@{#39131}

[ahaas, 2016-08-26 07:39:28]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 07:39:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 07:45:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 07:45:50]

Dry run: Try jobs failed on following builders:
  v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/13204)

[ahaas, 2016-08-26 07:49:28]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 07:49:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 08:11:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 08:11:49]

Dry run: This issue passed the CQ dry run.

[titzer, 2016-08-26 08:24:17]

https://codereview.chromium.org/2285643002/diff/20001/src/wasm/ast-decoder.h
File src/wasm/ast-decoder.h (right):

https://codereview.chromium.org/2285643002/diff/20001/src/wasm/ast-decoder.h#...
src/wasm/ast-decoder.h:188: inline MemoryAccessOperand(Decoder* decoder, const
byte* pc,
Why not just pass the maximum alignment size here? Then the LOAD_CASE macros can
get it from sizeof(ctype)?

[ahaas, 2016-08-30 19:03:02]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 19:03:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 19:29:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 19:29:38]

Dry run: This issue passed the CQ dry run.

[ahaas, 2016-09-01 17:18:29]

https://codereview.chromium.org/2285643002/diff/20001/src/wasm/ast-decoder.h
File src/wasm/ast-decoder.h (right):

https://codereview.chromium.org/2285643002/diff/20001/src/wasm/ast-decoder.h#...
src/wasm/ast-decoder.h:188: inline MemoryAccessOperand(Decoder* decoder, const
byte* pc,
On 2016/08/26 at 08:24:17, titzer wrote:
> Why not just pass the maximum alignment size here? Then the LOAD_CASE macros
can get it from sizeof(ctype)?

Done.

[titzer, 2016-09-02 07:46:23]

lgtm with comment

https://codereview.chromium.org/2285643002/diff/40001/src/wasm/ast-decoder.h
File src/wasm/ast-decoder.h (right):

https://codereview.chromium.org/2285643002/diff/40001/src/wasm/ast-decoder.h#...
src/wasm/ast-decoder.h:194: decoder->error(pc,
How about printing the expected maximum and the actual value as part of the
error message? You have to pass the position in that case.

[ahaas, 2016-09-02 11:35:06]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 11:35:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ahaas, 2016-09-02 11:35:30]

The CQ bit was unchecked by ahaas@chromium.org

[ahaas, 2016-09-02 11:35:32]

The CQ bit was checked by ahaas@chromium.org

[ahaas, 2016-09-02 11:35:33]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/2285643002/#ps60001
(title: "Add alignment and maximum alignment information to the error message.")

[commit-bot: I haz the power, 2016-09-02 11:35:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ahaas, 2016-09-02 11:35:46]

https://codereview.chromium.org/2285643002/diff/40001/src/wasm/ast-decoder.h
File src/wasm/ast-decoder.h (right):

https://codereview.chromium.org/2285643002/diff/40001/src/wasm/ast-decoder.h#...
src/wasm/ast-decoder.h:194: decoder->error(pc,
On 2016/09/02 at 07:46:23, titzer wrote:
> How about printing the expected maximum and the actual value as part of the
error message? You have to pass the position in that case.

Done.

[commit-bot: I haz the power, 2016-09-02 11:59:16]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-02 11:59:57]

Description was changed from

==========
[wasm] Validate the alignment of load and store instructions.

According to the WebAssembly specification the alignment of load and
store instructions has to be less or equal to natural alignment.

R=titzer@chromium.org
==========

to

==========
[wasm] Validate the alignment of load and store instructions.

According to the WebAssembly specification the alignment of load and
store instructions has to be less or equal to natural alignment.

R=titzer@chromium.org

Committed: https://crrev.com/6a892bb45111bf5f5dfd678e9995eb3957898136
Cr-Commit-Position: refs/heads/master@{#39131}
==========

[commit-bot: I haz the power, 2016-09-02 11:59:59]

Patchset 4 (id:??) landed as
https://crrev.com/6a892bb45111bf5f5dfd678e9995eb3957898136
Cr-Commit-Position: refs/heads/master@{#39131}