Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceManager.java

Issue 2285633004: [TTS] Record CTR by week and 28-day intervals. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ctr
Patch Set: Reworked the cache to use a stored preference instead of session static data. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceManager.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceManager.java
index c19b4c1367d56717097599fcc2798965b3f1c2fd..b069537c0d26559194619b3de331473218c2f029 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceManager.java
@@ -38,6 +38,8 @@ public class ChromePreferenceManager {
"contextual_search_last_animation_time";
private static final String CONTEXTUAL_SEARCH_TAP_QUICK_ANSWER_COUNT =
"contextual_search_tap_quick_answer_count";
+ private static final String CONTEXTUAL_SEARCH_CURRENT_WEEK_NUMBER =
+ "contextual_search_current_week_number";
private static final String HERB_FLAVOR_KEY = "herb_flavor";
private static final String INSTANT_APPS_KEY = "applink.app_link_enabled";
private static final String WEBAPK_RUNTIME_KEY = "webapk.runtime_enabled";
@@ -307,6 +309,21 @@ public class ChromePreferenceManager {
}
/**
+ * @return The current week number, persisted for weekly CTR recording.
+ */
+ public int getContextualSearchCurrentWeekNumber() {
+ return mSharedPreferences.getInt(CONTEXTUAL_SEARCH_CURRENT_WEEK_NUMBER, 0);
+ }
+
+ /**
+ * Sets the current week number to persist. Used for weekly CTR recording.
+ * @param weekNumber The week number to store.
+ */
+ public void setContextualSearchCurrentWeekNumber(int weekNumber) {
+ writeInt(CONTEXTUAL_SEARCH_CURRENT_WEEK_NUMBER, weekNumber);
+ }
+
+ /**
* @return Which UI prototype the user is testing. This is cached from native via
* {@link FeatureUtilities#cacheHerbFlavor}.
*/
@@ -357,17 +374,25 @@ public class ChromePreferenceManager {
/**
* Writes the given int value to the named shared preference.
- *
* @param key The name of the preference to modify.
* @param value The new value for the preference.
*/
- private void writeInt(String key, int value) {
+ public void writeInt(String key, int value) {
SharedPreferences.Editor ed = mSharedPreferences.edit();
ed.putInt(key, value);
ed.apply();
}
/**
+ * Reads the given int value from the named shared preference.
+ * @param key The name of the preference to return.
+ * @return The value of the preference.
+ */
+ public int readInt(String key) {
+ return mSharedPreferences.getInt(key, 0);
+ }
+
+ /**
* Writes the given String to the named shared preference.
*
* @param key The name of the preference to modify.

Powered by Google App Engine
This is Rietveld 408576698