components/contextual_search/browser/ctr_aggregator.cc - Issue 2285633004: [TTS] Record CTR by week and 28-day intervals.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/contextual_search/browser/ctr_aggregator.cc

Issue 2285633004: [TTS] Record CTR by week and 28-day intervals. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ctr

Patch Set: Added recording of impressions and getCurrentWeekNumber to invalidate the caching. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/contextual_search/browser/ctr_aggregator.cc

diff --git a/components/contextual_search/browser/ctr_aggregator.cc b/components/contextual_search/browser/ctr_aggregator.cc

index 3010e8093a63fce9d2f709152e39c20ad9191778..f7a6a5b01934b497f8f7cb35135529eab40bebc5 100644

--- a/components/contextual_search/browser/ctr_aggregator.cc

+++ b/components/contextual_search/browser/ctr_aggregator.cc

@@ -44,6 +44,10 @@ void CTRAggregator::RecordImpression(bool did_click) {

storage_.WriteClicks(week_number_, 1 + storage_.ReadClicks(week_number_));

}

+int CTRAggregator::GetCurrentWeekNumber() {

+ return week_number_;

bool CTRAggregator::HasPreviousWeekData() {

return storage_.HasData(week_number_ - 1);

}