Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: chrome/browser/android/contextualsearch/ctr_recorder.cc

Issue 2285633004: [TTS] Record CTR by week and 28-day intervals. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ctr
Patch Set: Added recording of impressions and getCurrentWeekNumber to invalidate the caching. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/contextualsearch/ctr_recorder.cc
diff --git a/chrome/browser/android/contextualsearch/ctr_recorder.cc b/chrome/browser/android/contextualsearch/ctr_recorder.cc
new file mode 100644
index 0000000000000000000000000000000000000000..ab0d5895a3c62d672ecb4830ceb9cb1c43fdf99e
--- /dev/null
+++ b/chrome/browser/android/contextualsearch/ctr_recorder.cc
@@ -0,0 +1,108 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/android/contextualsearch/ctr_recorder.h"
+
+#include <set>
+
+#include "base/android/jni_string.h"
+#include "base/android/scoped_java_ref.h"
+#include "jni/CTRRecorder_jni.h"
+
+using base::android::AttachCurrentThread;
+using base::android::ConvertUTF8ToJavaString;
+using base::android::JavaParamRef;
+using base::android::ScopedJavaLocalRef;
+using contextual_search::CTRAggregator;
+
+CTRRecorder::CTRRecorder(JNIEnv* env, jobject obj)
+ : WeeklyActivityStorage(contextual_search::kNumWeeksNeededFor28DayData) {
+ java_object_.Reset(env, obj);
+
+ // NOTE: Creating the aggregator needs to be done after setting up the Java
+ // object because the constructor will call back through the Java object
+ // to access storage.
+ aggregator_.reset(new CTRAggregator(*this));
+ DCHECK(aggregator_);
+}
+
+CTRRecorder::~CTRRecorder() {
+ JNIEnv* env = AttachCurrentThread();
+ Java_CTRRecorder_clearNativePointer(env, java_object_.obj());
+}
+
+// Java conduit
+
+void CTRRecorder::RecordImpression(JNIEnv* env,
+ const JavaParamRef<jobject>& obj,
+ jboolean did_click) {
+ aggregator_->RecordImpression(did_click);
+}
+
+jint CTRRecorder::GetCurrentWeekNumber(JNIEnv* env,
+ const JavaParamRef<jobject>& obj) {
+ return aggregator_->GetCurrentWeekNumber();
+}
+
+jboolean CTRRecorder::HasPreviousWeekData(JNIEnv* env,
+ const JavaParamRef<jobject>& obj) {
+ return aggregator_->HasPreviousWeekData();
+}
+
+jint CTRRecorder::GetPreviousWeekImpressions(JNIEnv* env,
+ const JavaParamRef<jobject>& obj) {
+ return aggregator_->GetPreviousWeekImpressions();
+}
+
+jfloat CTRRecorder::GetPreviousWeekCTR(JNIEnv* env,
+ const JavaParamRef<jobject>& obj) {
+ return aggregator_->GetPreviousWeekCTR();
+}
+
+jboolean CTRRecorder::HasPrevious28DayData(JNIEnv* env,
+ const JavaParamRef<jobject>& obj) {
+ return aggregator_->HasPrevious28DayData();
+}
+
+jint CTRRecorder::GetPrevious28DayImpressions(
+ JNIEnv* env,
+ const JavaParamRef<jobject>& obj) {
+ return aggregator_->GetPrevious28DayImpressions();
+}
+
+jfloat CTRRecorder::GetPrevious28DayCTR(JNIEnv* env,
+ const JavaParamRef<jobject>& obj) {
+ return aggregator_->GetPrevious28DayCTR();
+}
+
+// WeeklyActivityStorage overrides
+
+int CTRRecorder::ReadStorage(std::string storage_bucket) {
+ JNIEnv* env = AttachCurrentThread();
+ ScopedJavaLocalRef<jstring> j_storage_bucket =
+ ConvertUTF8ToJavaString(env, storage_bucket.c_str());
+ return Java_CTRRecorder_readInt(env, java_object_, j_storage_bucket);
+}
+
+void CTRRecorder::WriteStorage(std::string storage_bucket, int value) {
+ JNIEnv* env = AttachCurrentThread();
+ ScopedJavaLocalRef<jstring> j_storage_bucket =
+ ConvertUTF8ToJavaString(env, storage_bucket.c_str());
+ Java_CTRRecorder_writeInt(env, java_object_, j_storage_bucket, value);
+}
+
+// Java wrapper boilerplate
+
+void CTRRecorder::Destroy(JNIEnv* env, const JavaParamRef<jobject>& obj) {
+ delete this;
+}
+
+bool RegisterCTRRecorder(JNIEnv* env) {
+ return RegisterNativesImpl(env);
+}
+
+jlong Init(JNIEnv* env, const JavaParamRef<jobject>& obj) {
+ CTRRecorder* recorder = new CTRRecorder(env, obj);
+ return reinterpret_cast<intptr_t>(recorder);
+}

Powered by Google App Engine
This is Rietveld 408576698