Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3551)

Unified Diff: base/threading/sequenced_worker_pool.h

Issue 2285633003: Test SequencedWorkerPool with redirection to the TaskScheduler. (Closed)
Patch Set: Rewrote everything Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/threading/sequenced_worker_pool.cc » ('j') | base/threading/sequenced_worker_pool.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/threading/sequenced_worker_pool.h
diff --git a/base/threading/sequenced_worker_pool.h b/base/threading/sequenced_worker_pool.h
index 18603b3c7cfbe8f2b5886a92aa48589385343b6f..c150983e0bd5d0d49dac186652c0fd13988f3d3f 100644
--- a/base/threading/sequenced_worker_pool.h
+++ b/base/threading/sequenced_worker_pool.h
@@ -172,16 +172,27 @@ class BASE_EXPORT SequencedWorkerPool : public TaskRunner {
// PostSequencedWorkerTask(). Valid tokens are always nonzero.
static SequenceToken GetSequenceToken();
- // Invoke this once on the main thread of a process, before any other threads
- // are created and before any tasks are posted to that process'
- // SequencedWorkerPools but after TaskScheduler was instantiated, to force all
- // SequencedWorkerPools in that process to redirect their tasks to the
- // TaskScheduler. Note: SequencedWorkerPool instances with |max_threads == 1|
- // will be special cased to send all of their work as
- // ExecutionMode::SINGLE_THREADED.
+ // Starts redirecting tasks posted to this process' SequencedWorkerPools to
+ // the registered TaskScheduler. This cannot be called after a task has been
+ // posted to a SequencedWorkerPool. This is not thread-safe; proper
+ // synchronization is required to use any SequencedWorkerPool method after
+ // calling this. There must be a registered TaskScheduler when this is called.
+ // Ideally, call this on the main thread of a process, before any other
+ // threads are created and before any tasks are posted to that process'
+ // SequencedWorkerPools.
+ // Note: SequencedWorkerPool instances with |max_threads == 1| will be special
+ // cased to send all of their work as ExecutionMode::SINGLE_THREADED.
// TODO(gab): Remove this if http://crbug.com/622400 fails
// (SequencedWorkerPool will be phased out completely otherwise).
- static void RedirectSequencedWorkerPoolsToTaskSchedulerForProcess();
+ static void RedirectToTaskSchedulerForProcess();
+
+ // Stops redirecting tasks posted to this process' SequencedWorkerPools to the
+ // registered TaskScheduler and allows RedirectToTaskSchedulerForProcess() to
+ // be called even if tasks have already posted to a SequencedWorkerPool in
+ // this process. Calling this while there are active SequencedWorkerPools is
+ // not supported. This is not thread-safe; proper synchronization is required
+ // to use any SequencedWorkerPool method after calling this.
+ static void ResetRedirectToTaskSchedulerForProcessForTesting();
// When constructing a SequencedWorkerPool, there must be a
// ThreadTaskRunnerHandle on the current thread unless you plan to
« no previous file with comments | « no previous file | base/threading/sequenced_worker_pool.cc » ('j') | base/threading/sequenced_worker_pool.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698