Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Unified Diff: content/browser/android/child_process_launcher_android.cc

Issue 2285593002: Add ScopedSurfaceRequestManager (Closed)
Patch Set: Update to UnguessableToken. Addressed comments. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/android/child_process_launcher_android.cc
diff --git a/content/browser/android/child_process_launcher_android.cc b/content/browser/android/child_process_launcher_android.cc
index e66ed0014e0534d161009675ec19d5784088f8ea..8456f0cf4e438aec17d75b9f51b2953c52c5098d 100644
--- a/content/browser/android/child_process_launcher_android.cc
+++ b/content/browser/android/child_process_launcher_android.cc
@@ -13,7 +13,9 @@
#include "base/android/context_utils.h"
#include "base/android/jni_android.h"
#include "base/android/jni_array.h"
+#include "base/android/jni_string.h"
#include "base/logging.h"
+#include "content/browser/android/scoped_surface_request_manager.h"
#include "content/browser/file_descriptor_info_impl.h"
#include "content/browser/frame_host/render_frame_host_impl.h"
#include "content/browser/media/android/browser_media_player_manager.h"
@@ -237,6 +239,24 @@ void EstablishSurfacePeer(JNIEnv* env,
&SetSurfacePeer, jsurface, pid, primary_id, secondary_id));
}
+void CompleteScopedSurfaceRequest(JNIEnv* env,
+ const JavaParamRef<jclass>& clazz,
+ jlong request_token_high,
+ jlong request_token_low,
+ const JavaParamRef<jobject>& surface) {
+ if (request_token_high == 0 && request_token_low == 0)
tguilbert 2016/09/20 03:08:40 Thoughts on whether this should be logged?
dcheng 2016/09/20 06:50:35 It's fine to add something like a DLOG(), but it's
+ return;
+
+ DCHECK(!BrowserThread::CurrentlyOn(BrowserThread::UI));
+
+ ScopedJavaGlobalRef<jobject> jsurface;
+ jsurface.Reset(env, surface);
+ ScopedSurfaceRequestManager::GetInstance()->FulfillScopedSurfaceRequest(
+ base::UnguessableToken::Deserialize(request_token_high,
+ request_token_low),
+ gl::ScopedJavaSurface(jsurface));
+}
+
void RegisterViewSurface(int surface_id, const JavaRef<jobject>& j_surface) {
JNIEnv* env = AttachCurrentThread();
DCHECK(env);

Powered by Google App Engine
This is Rietveld 408576698