Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 2285563002: Revert of Desktop Chrome OS: Build with precise sysroot (Closed)

Created:
4 years, 3 months ago by jianli
Modified:
4 years, 3 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Desktop Chrome OS: Build with precise sysroot (patchset #2 id:40001 of https://codereview.chromium.org/2272273002/ ) Reason for revert: Caused webview_licenses failure: https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/31063 Original issue's description: > Desktop Chrome OS: Build with precise sysroot > > Build and link against the Ubuntu Precise amd64 sysroot on Desktop > Chrome OS instead of always using the system libraries. > > BUG=638394 > > Committed: https://crrev.com/c575bbcd130b38994e36b0a97bfe5ceea954a643 > Cr-Commit-Position: refs/heads/master@{#414564} TBR=dpranke@chromium.org,thomasanderson@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=638394 Committed: https://crrev.com/faa5e808ff90870b5b5b35c65e931eec5d6285cc Cr-Commit-Position: refs/heads/master@{#414594}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -103 lines) Patch
M build/config/sysroot.gni View 1 chunk +13 lines, -22 lines 0 comments Download
M build/linux/sysroot_scripts/install-sysroot.py View 6 chunks +57 lines, -81 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jianli
Created Revert of Desktop Chrome OS: Build with precise sysroot
4 years, 3 months ago (2016-08-26 00:18:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2285563002/1
4 years, 3 months ago (2016-08-26 00:18:47 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-26 00:20:29 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/faa5e808ff90870b5b5b35c65e931eec5d6285cc Cr-Commit-Position: refs/heads/master@{#414594}
4 years, 3 months ago (2016-08-26 00:31:07 UTC) #7
Dirk Pranke
4 years, 3 months ago (2016-08-26 00:36:33 UTC) #8
Message was sent while issue was closed.
lgtm, thanks for the revert.

Powered by Google App Engine
This is Rietveld 408576698