Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1732)

Unified Diff: chrome/browser/engagement/site_engagement_score_unittest.cc

Issue 2285553002: [HBD] Gate the advertising of Flash on Site Engagement. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address nit Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/engagement/site_engagement_score_unittest.cc
diff --git a/chrome/browser/engagement/site_engagement_score_unittest.cc b/chrome/browser/engagement/site_engagement_score_unittest.cc
index 625b75c34ce69725e68ec84d64d0fb482cd259f7..51e32258e4281638f5359e992ca2bc9a20e57f65 100644
--- a/chrome/browser/engagement/site_engagement_score_unittest.cc
+++ b/chrome/browser/engagement/site_engagement_score_unittest.cc
@@ -44,7 +44,7 @@ base::Time GetReferenceTime() {
class SiteEngagementScoreTest : public testing::Test {
public:
- SiteEngagementScoreTest() : score_(&test_clock_, nullptr) {}
+ SiteEngagementScoreTest() : score_(&test_clock_, GURL(), nullptr) {}
void SetUp() override {
testing::Test::SetUp();
@@ -77,7 +77,8 @@ class SiteEngagementScoreTest : public testing::Test {
double expected_points_added_today,
base::Time expected_last_engagement_time) {
std::unique_ptr<base::DictionaryValue> copy(score_dict->DeepCopy());
- SiteEngagementScore initial_score(&test_clock_, std::move(score_dict));
+ SiteEngagementScore initial_score(&test_clock_, GURL(),
+ std::move(score_dict));
VerifyScore(initial_score, expected_raw_score, expected_points_added_today,
expected_last_engagement_time);
@@ -91,7 +92,7 @@ class SiteEngagementScoreTest : public testing::Test {
GetReferenceTime() + base::TimeDelta::FromDays(1);
UpdateScore(&initial_score, 5, 10, different_day);
EXPECT_TRUE(initial_score.UpdateScoreDict(copy.get()));
- SiteEngagementScore updated_score(&test_clock_, std::move(copy));
+ SiteEngagementScore updated_score(&test_clock_, GURL(), std::move(copy));
VerifyScore(updated_score, 5, 10, different_day);
}
@@ -328,9 +329,9 @@ TEST_F(SiteEngagementScoreTest, PopulatedDictionary) {
TEST_F(SiteEngagementScoreTest, FirstDailyEngagementBonus) {
SetParamValue(SiteEngagementScore::FIRST_DAILY_ENGAGEMENT, 0.5);
- SiteEngagementScore score1(&test_clock_,
+ SiteEngagementScore score1(&test_clock_, GURL(),
std::unique_ptr<base::DictionaryValue>());
- SiteEngagementScore score2(&test_clock_,
+ SiteEngagementScore score2(&test_clock_, GURL(),
std::unique_ptr<base::DictionaryValue>());
base::Time current_day = GetReferenceTime();
« no previous file with comments | « chrome/browser/engagement/site_engagement_score.cc ('k') | chrome/browser/engagement/site_engagement_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698