Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: chrome/browser/engagement/site_engagement_score.h

Issue 2285553002: [HBD] Gate the advertising of Flash on Site Engagement. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address nit Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/engagement/site_engagement_score.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/engagement/site_engagement_score.h
diff --git a/chrome/browser/engagement/site_engagement_score.h b/chrome/browser/engagement/site_engagement_score.h
index 70619da395e30033b954003eb31e8f43ea47960e..51a2523227a5042c79e18f929cf43147b112ad2a 100644
--- a/chrome/browser/engagement/site_engagement_score.h
+++ b/chrome/browser/engagement/site_engagement_score.h
@@ -18,7 +18,7 @@ namespace base {
class Clock;
}
-class Profile;
+class HostContentSettingsMap;
class SiteEngagementScore {
public:
@@ -114,7 +114,7 @@ class SiteEngagementScore {
// SiteEngagementScore.
SiteEngagementScore(base::Clock* clock,
const GURL& origin,
- Profile* profile);
+ HostContentSettingsMap* settings);
SiteEngagementScore(SiteEngagementScore&& other);
~SiteEngagementScore();
@@ -161,6 +161,7 @@ class SiteEngagementScore {
friend class SiteEngagementHelperTest;
friend class SiteEngagementScoreTest;
friend class SiteEngagementServiceTest;
+ friend class ChromePluginServiceFilterTest;
using ParamValues = std::array<std::pair<std::string, double>, MAX_VARIATION>;
@@ -176,6 +177,7 @@ class SiteEngagementScore {
// This version of the constructor is used in unit tests.
SiteEngagementScore(base::Clock* clock,
+ const GURL& origin,
std::unique_ptr<base::DictionaryValue> score_dict);
// Determine the score, accounting for any decay.
@@ -218,8 +220,8 @@ class SiteEngagementScore {
// The origin this score represents.
GURL origin_;
- // The profile to write this score to when Commit() is called.
- Profile* profile_;
+ // The settings to write this score to when Commit() is called.
+ HostContentSettingsMap* settings_map_;
DISALLOW_COPY_AND_ASSIGN(SiteEngagementScore);
};
« no previous file with comments | « no previous file | chrome/browser/engagement/site_engagement_score.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698