[HBD] Gate the advertising of Flash on Site Engagement.

chrome/browser/engagement/site_engagement_score.h

Index: chrome/browser/engagement/site_engagement_score.h
diff --git a/chrome/browser/engagement/site_engagement_score.h b/chrome/browser/engagement/site_engagement_score.h
index 70619da395e30033b954003eb31e8f43ea47960e..2e0e53b62105785d14da90f7a627ee055b258517 100644
--- a/chrome/browser/engagement/site_engagement_score.h
+++ b/chrome/browser/engagement/site_engagement_score.h
@@ -18,7 +18,7 @@ namespace base {
 class Clock;
 }
 
-class Profile;
+class HostContentSettingsMap;
 
 class SiteEngagementScore {
  public:
@@ -114,7 +114,7 @@ class SiteEngagementScore {
   // SiteEngagementScore.
   SiteEngagementScore(base::Clock* clock,
                       const GURL& origin,
-                      Profile* profile);
+                      HostContentSettingsMap* settings);
   SiteEngagementScore(SiteEngagementScore&& other);
   ~SiteEngagementScore();
 
@@ -176,6 +176,7 @@ class SiteEngagementScore {
 
   // This version of the constructor is used in unit tests.
   SiteEngagementScore(base::Clock* clock,
+                      const GURL& origin,

[calamity, 2016/09/13 04:14:37]

Is this used anywhere?

[dominickn, 2016/09/13 04:42:14]

The GURL argument? I pulled it down so that there would be one less argument
outside the initializer list. It made sense just to have that in the delegated
constructor.

The underlying origin_ member is used as the key when saving to content
settings.

[calamity, 2016/09/13 06:33:34]

Seems weird to have a param that's never used but I'll leave it to you.

[dominickn, 2016/09/14 01:06:55]

Acknowledged.

                       std::unique_ptr<base::DictionaryValue> score_dict);
 
   // Determine the score, accounting for any decay.
@@ -218,8 +219,8 @@ class SiteEngagementScore {
   // The origin this score represents.
   GURL origin_;
 
-  // The profile to write this score to when Commit() is called.
-  Profile* profile_;
+  // The settings to write this score to when Commit() is called.
+  HostContentSettingsMap* settings_map_;
 
   DISALLOW_COPY_AND_ASSIGN(SiteEngagementScore);
 };