Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: chrome/browser/chromeos/settings/device_settings_provider.cc

Issue 228553002: Preference dis/allowing supervised users creation is now available as owner setting, not only as de… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Logic for default settings moved to device_settings_provider. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/settings/device_settings_provider.cc
diff --git a/chrome/browser/chromeos/settings/device_settings_provider.cc b/chrome/browser/chromeos/settings/device_settings_provider.cc
index e38b877f9cb2ddcb17c9bd2d07321b829d2c9089..c9fb947a83d1ff1b39dc3d0b5386d3aa162f55d3 100644
--- a/chrome/browser/chromeos/settings/device_settings_provider.cc
+++ b/chrome/browser/chromeos/settings/device_settings_provider.cc
@@ -215,6 +215,14 @@ void DeviceSettingsProvider::SetInPolicy() {
guest->set_guest_mode_enabled(guest_value);
else
NOTREACHED();
+ } else if (prop == kAccountsPrefSupervisedUsersEnabled) {
+ em::SupervisedUsersSettingsProto* supervised =
+ device_settings_.mutable_supervised_users_settings();
+ bool supervised_value;
+ if (value->GetAsBoolean(&supervised_value))
+ supervised->set_supervised_users_enabled(supervised_value);
+ else
+ NOTREACHED();
} else if (prop == kAccountsPrefShowUserNamesOnSignIn) {
em::ShowUserNamesOnSigninProto* show =
device_settings_.mutable_show_user_names();
@@ -386,7 +394,6 @@ void DeviceSettingsProvider::SetInPolicy() {
} else {
// The remaining settings don't support Set(), since they are not
// intended to be customizable by the user:
- // kAccountsPrefSupervisedUsersEnabled
// kAppPack
// kDeviceAttestationEnabled
// kDeviceOwner
@@ -436,6 +443,8 @@ void DeviceSettingsProvider::DecodeLoginPolicies(
// true is default permissive value and false is safe prohibitive value.
// Exceptions:
// kAccountsPrefEphemeralUsersEnabled has a default value of false.
+ // kAccountsPrefSupervisedUsersEnabled has a default value of false
+ // for enterprise devices and true for consumer devices.
if (policy.has_allow_new_users() &&
policy.allow_new_users().has_allow_new_users()) {
if (policy.allow_new_users().allow_new_users()) {
@@ -459,6 +468,29 @@ void DeviceSettingsProvider::DecodeLoginPolicies(
!policy.guest_mode_enabled().has_guest_mode_enabled() ||
policy.guest_mode_enabled().guest_mode_enabled());
+ policy::BrowserPolicyConnectorChromeOS* connector =
+ g_browser_process->platform_part()->browser_policy_connector_chromeos();
+ bool supervised_users_enabled = false;
+ if (connector->IsEnterpriseManaged()) {
+ supervised_users_enabled =
+ policy.has_supervised_users_settings() &&
+ policy.supervised_users_settings().has_supervised_users_enabled() &&
+ policy.supervised_users_settings().supervised_users_enabled();
+ } else {
+ supervised_users_enabled =
+ !policy.has_supervised_users_settings() ||
+ !policy.supervised_users_settings().has_supervised_users_enabled() ||
+ policy.supervised_users_settings().supervised_users_enabled();
+ }
+ new_values_cache->SetBoolean(
+ kAccountsPrefSupervisedUsersEnabled, supervised_users_enabled);
pastarmovj 2014/04/15 08:54:28 There is some issue here - the code below will ove
merkulova 2014/04/15 09:23:58 Done.
+
+ new_values_cache->SetBoolean(
+ kAccountsPrefSupervisedUsersEnabled,
pastarmovj 2014/04/15 08:54:28 ...this here I mean.
merkulova 2014/04/15 09:23:58 Done.
+ !policy.has_supervised_users_settings() ||
+ !policy.supervised_users_settings().has_supervised_users_enabled() ||
+ policy.supervised_users_settings().supervised_users_enabled());
+
new_values_cache->SetBoolean(
kAccountsPrefShowUserNamesOnSignIn,
!policy.has_show_user_names() ||
« no previous file with comments | « chrome/browser/chromeos/login/webui_screen_locker.cc ('k') | chrome/browser/chromeos/settings/stub_cros_settings_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698