Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(965)

Issue 2285513002: Remove CFX_CountRef::IsNull in favor of operator bool (Closed)

Created:
4 years, 3 months ago by Tom Sepez
Modified:
4 years, 3 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@retain_again
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove CFX_CountRef::IsNull in favor of operator bool Committed: https://pdfium.googlesource.com/pdfium/+/83d2351fd64128156c9abfb70266133d58a5e525

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 2

Patch Set 3 : Rebase, FX_BOOL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -36 lines) Patch
M core/fpdfapi/fpdf_page/cpdf_pageobject.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_pathobject.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_shadingobject.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M core/fpdfapi/fpdf_page/fpdf_page_parser.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp View 2 chunks +5 lines, -9 lines 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render.cpp View 1 2 5 chunks +10 lines, -12 lines 0 comments Download
M core/fxcrt/include/cfx_count_ref.h View 1 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Tom Sepez
Lei, small follow-on.
4 years, 3 months ago (2016-08-26 18:05:23 UTC) #4
Lei Zhang
lgtm not not nice. https://codereview.chromium.org/2285513002/diff/20001/core/fpdfapi/fpdf_render/fpdf_render.cpp File core/fpdfapi/fpdf_render/fpdf_render.cpp (right): https://codereview.chromium.org/2285513002/diff/20001/core/fpdfapi/fpdf_render/fpdf_render.cpp#newcode716 core/fpdfapi/fpdf_render/fpdf_render.cpp:716: FX_BOOL bTextClip = bool?
4 years, 3 months ago (2016-08-26 20:56:09 UTC) #7
Tom Sepez
https://codereview.chromium.org/2285513002/diff/20001/core/fpdfapi/fpdf_render/fpdf_render.cpp File core/fpdfapi/fpdf_render/fpdf_render.cpp (right): https://codereview.chromium.org/2285513002/diff/20001/core/fpdfapi/fpdf_render/fpdf_render.cpp#newcode716 core/fpdfapi/fpdf_render/fpdf_render.cpp:716: FX_BOOL bTextClip = On 2016/08/26 20:56:09, Lei Zhang wrote: ...
4 years, 3 months ago (2016-08-26 21:36:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2285513002/40001
4 years, 3 months ago (2016-08-26 21:37:04 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 21:56:42 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/83d2351fd64128156c9abfb70266133d58a5...

Powered by Google App Engine
This is Rietveld 408576698