Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 22855008: Support a runtime flag for navigator content utils feature (Closed)

Created:
7 years, 4 months ago by gyuyoung-inactive
Modified:
7 years, 4 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, jamesr, dglazkov+blink, eae+blinkwatch
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Support a runtime flag for navigator content utils feature Add a runtime flag for navigator content utils feature. This patch exposes in the public API so that they can be toggled. BUG= N/A

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
M Source/core/page/RuntimeEnabledFeatures.in View 1 chunk +1 line, -0 lines 2 comments Download
M Source/modules/navigatorcontentutils/NavigatorContentUtils.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebRuntimeFeatures.cpp View 1 chunk +16 lines, -0 lines 0 comments Download
M public/web/WebRuntimeFeatures.h View 1 chunk +3 lines, -0 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
gyuyoung-inactive
Add abarth to reviewers.
7 years, 4 months ago (2013-08-18 05:09:54 UTC) #1
abarth-chromium
https://codereview.chromium.org/22855008/diff/1/Source/core/page/RuntimeEnabledFeatures.in File Source/core/page/RuntimeEnabledFeatures.in (right): https://codereview.chromium.org/22855008/diff/1/Source/core/page/RuntimeEnabledFeatures.in#newcode64 Source/core/page/RuntimeEnabledFeatures.in:64: NavigatorContentUtils status=stable Show they be turned on in stable? ...
7 years, 4 months ago (2013-08-19 19:18:07 UTC) #2
gyuyoung-inactive
https://codereview.chromium.org/22855008/diff/1/Source/core/page/RuntimeEnabledFeatures.in File Source/core/page/RuntimeEnabledFeatures.in (right): https://codereview.chromium.org/22855008/diff/1/Source/core/page/RuntimeEnabledFeatures.in#newcode64 Source/core/page/RuntimeEnabledFeatures.in:64: NavigatorContentUtils status=stable On 2013/08/19 19:18:07, abarth wrote: > Show ...
7 years, 4 months ago (2013-08-20 08:24:36 UTC) #3
abarth-chromium
On 2013/08/20 08:24:36, gyuyoung wrote: > I don't understand well. Stable APIs as Geolocation, MediaStream ...
7 years, 4 months ago (2013-08-20 19:22:27 UTC) #4
gyuyoung-inactive
7 years, 4 months ago (2013-08-21 01:36:02 UTC) #5
On 2013/08/20 19:22:27, abarth wrote:
> On 2013/08/20 08:24:36, gyuyoung wrote:
> > I don't understand well. Stable APIs as Geolocation, MediaStream were added
to
> > here. Could you let me know what is difference ?
> 
> They weren't stable when the flags were created.  We should probably remove
the
> flags.  We don't need the ability to disable the features anymore.

Ok, If so, I would like to close this issue. When I have time, I will suggest
this issue on blink-dev. Thanks.

Powered by Google App Engine
This is Rietveld 408576698