Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Unified Diff: mojo/common/common_custom_types_struct_traits.cc

Issue 2285433002: Use compositor_frame typemap in Blink (Closed)
Patch Set: Do not write empty function in content Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/common/common_custom_types_struct_traits.cc
diff --git a/mojo/common/common_custom_types_struct_traits.cc b/mojo/common/common_custom_types_struct_traits.cc
index 62e2d6385e4f5ff3403b0326450b136d42487591..232f8977a9af53a92f7279790866be1800f8b35b 100644
--- a/mojo/common/common_custom_types_struct_traits.cc
+++ b/mojo/common/common_custom_types_struct_traits.cc
@@ -11,6 +11,18 @@
namespace mojo {
// static
+bool StructTraits<mojo::common::mojom::VersionDataView, base::Version>::IsNull(
+ const base::Version& version) {
+ return !version.IsValid();
yzshen1 2016/09/01 00:02:54 can these short methods stay in the .h file? That
xlai (Olivia) 2016/09/01 16:57:44 Done.
+}
+
+// static
+void StructTraits<mojo::common::mojom::VersionDataView,
+ base::Version>::SetToNull(base::Version* out) {
+ *out = base::Version(std::string());
+}
+
+// static
const std::vector<uint32_t>&
StructTraits<mojo::common::mojom::VersionDataView, base::Version>::components(
const base::Version& version) {

Powered by Google App Engine
This is Rietveld 408576698