Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 22854025: Use the externally_connectable schema from manifest_types.json to generate its (Closed)

Created:
7 years, 4 months ago by not at google - send to devlin
Modified:
7 years, 4 months ago
Reviewers:
miket_OOO
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Use the externally_connectable schema from manifest_types.json to generate its documentation. R=miket@chromium.org BUG=275944 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218852

Patch Set 1 #

Patch Set 2 : cleanup #

Total comments: 4

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+193 lines, -134 lines) Patch
M chrome/common/extensions/api/_api_features.json View 1 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/manifest_types.json View 1 2 2 chunks +7 lines, -6 lines 0 comments Download
M chrome/common/extensions/docs/server2/api_data_source.py View 1 1 chunk +11 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/server2/app.yaml View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/cron.yaml View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/test_data/test_json/expected_test_file.json View 1 1 chunk +1 line, -1 line 0 comments Download
D chrome/common/extensions/docs/static/css/api.css View 1 chunk +0 lines, -42 lines 0 comments Download
M chrome/common/extensions/docs/static/css/site.css View 1 2 23 chunks +111 lines, -66 lines 0 comments Download
A chrome/common/extensions/docs/templates/articles/manifest/externally_connectable.html View 1 2 1 chunk +38 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/templates/json/manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/private/api_reference.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/private/function_details.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/private/intro_table.html View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/templates/private/property.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/private/standard_apps_api.html View 1 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/common/extensions/docs/templates/private/standard_extensions_api.html View 1 2 chunks +3 lines, -4 lines 0 comments Download
A chrome/common/extensions/docs/templates/public/apps/manifest/externally_connectable.html View 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/common/extensions/docs/templates/public/extensions/manifest/externally_connectable.html View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
not at google - send to devlin
Hey Mike, your first docserver review! This is a nice one. Touches basically everything: the ...
7 years, 4 months ago (2013-08-19 22:06:19 UTC) #1
miket_OOO
LGTM. I'll patch locally and give it a try, but go ahead meanwhile. https://codereview.chromium.org/22854025/diff/3001/chrome/common/extensions/api/manifest_types.json File ...
7 years, 4 months ago (2013-08-21 19:32:37 UTC) #2
not at google - send to devlin
https://codereview.chromium.org/22854025/diff/3001/chrome/common/extensions/api/manifest_types.json File chrome/common/extensions/api/manifest_types.json (right): https://codereview.chromium.org/22854025/diff/3001/chrome/common/extensions/api/manifest_types.json#newcode20 chrome/common/extensions/api/manifest_types.json:20: "description": "<p>The IDs of extensions or apps that are ...
7 years, 4 months ago (2013-08-21 22:44:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/22854025/10001
7 years, 4 months ago (2013-08-21 22:46:55 UTC) #4
commit-bot: I haz the power
7 years, 4 months ago (2013-08-21 22:53:18 UTC) #5
Message was sent while issue was closed.
Change committed as 218852

Powered by Google App Engine
This is Rietveld 408576698