Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 2285393004: Replace deprecated ScopedVector<T> in chromeos::SimpleGeolocationProvider (Closed)

Created:
4 years, 3 months ago by Ben Chan
Modified:
4 years, 3 months ago
Reviewers:
Alexander Alekseev
CC:
chromium-reviews, alemate+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace deprecated ScopedVector<T> in chromeos::SimpleGeolocationProvider This CL changes chromeos::SimpleGeolocationProvider to use vector<unique_ptr<T>> instead of the deprecated ScopedVector<T>. BUG=554289 Committed: https://crrev.com/6f8ca9fb974d3f79b782506b8bd3d59416c5f610 Cr-Commit-Position: refs/heads/master@{#415289}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -6 lines) Patch
M chromeos/geolocation/simple_geolocation_provider.h View 2 chunks +4 lines, -2 lines 0 comments Download
M chromeos/geolocation/simple_geolocation_provider.cc View 3 chunks +8 lines, -3 lines 0 comments Download
M chromeos/geolocation/simple_geolocation_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
Ben Chan
4 years, 3 months ago (2016-08-30 06:20:37 UTC) #5
Alexander Alekseev
lgtm
4 years, 3 months ago (2016-08-30 06:38:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2285393004/1
4 years, 3 months ago (2016-08-30 14:10:59 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 14:14:30 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 14:16:50 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6f8ca9fb974d3f79b782506b8bd3d59416c5f610
Cr-Commit-Position: refs/heads/master@{#415289}

Powered by Google App Engine
This is Rietveld 408576698