Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(832)

Issue 2285363002: [NOT FOR REVIEW] calc visible rect dynamically

Created:
4 years, 3 months ago by weiliangc
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NOT FOR REVIEW] calc visible rect dynamically This is an example of what this calculation could look like. This CL needs step to verify calculation. Also this CL currently fails many unittests which need investigation. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -167 lines) Patch
M cc/trees/draw_property_utils.cc View 1 chunk +25 lines, -167 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
weiliangc
4 years, 3 months ago (2016-08-29 18:45:26 UTC) #2
List of failed unittests:
    GpuRasterizationRasterizesBorderTiles.RunMultiThread_DelegatingRenderer
(../../cc/trees/layer_tree_host_unittest.cc:5996)
    GpuRasterizationRasterizesBorderTiles.RunSingleThread_DelegatingRenderer
(../../cc/trees/layer_tree_host_unittest.cc:5996)
    LayerTreeHostCommonTest.ChangeTransformOrigin
(../../cc/trees/layer_tree_host_common_unittest.cc:8235)
    LayerTreeHostCommonTest.DrawableAndVisibleContentRectsForSimpleLayers
(../../cc/trees/layer_tree_host_common_unittest.cc:3062)
    LayerTreeHostCommonTest.DrawableAndVisibleContentRectsForSurfaceHierarchy
(../../cc/trees/layer_tree_host_common_unittest.cc:3715)
    LayerTreeHostCommonTest.DrawableAndVisibleContentRectsInHighDPI
(../../cc/trees/layer_tree_host_common_unittest.cc:4064)
   
LayerTreeHostCommonTest.DrawableAndVisibleRectsWhenCannotRenderToSeparateSurface
(../../cc/trees/layer_tree_host_common_unittest.cc:3206)
    LayerTreeHostCommonTest.LargeTransforms
(../../cc/trees/layer_tree_host_common_unittest.cc:2679)
    LayerTreeHostCommonTest.RenderSurfaceClipsSubtree
(../../cc/trees/layer_tree_host_common_unittest.cc:8772)
    LayerTreeHostCommonTest.RootClipPropagationToClippedSurface
(../../cc/trees/layer_tree_host_common_unittest.cc:3931)
    LayerTreeHostCommonTest.SublayerScaleWithTransformNodeBetweenTwoTargets
(../../cc/trees/layer_tree_host_common_unittest.cc:9323)
    LayerTreeHostCommonTest.UpdateScrollChildPosition
(../../cc/trees/layer_tree_host_common_unittest.cc:8258)
   
LayerTreeHostCommonTest.VisibleContentRectForAnimatedLayerWithSingularTransform
(../../cc/trees/layer_tree_host_common_unittest.cc:7939)
    LayerTreeHostCommonTest.VisibleContentRectInChildRenderSurface
(../../cc/trees/layer_tree_host_common_unittest.cc:7769)
    LayerTreeHostCommonTest.VisibleContentRectsForClippedSurfaceWithEmptyClip
(../../cc/trees/layer_tree_host_common_unittest.cc:3387)
    LayerTreeHostCommonTest.VisibleRectsForClippedDescendantsOfUnclippedSurfaces
(../../cc/trees/layer_tree_host_common_unittest.cc:3775)
    LayerTreeHostCommonTest.VisibleRectsForPositionedRootLayerClippedByViewport
(../../cc/trees/layer_tree_host_common_unittest.cc:3046)
    LayerTreeHostImplTest.ExternalTransformAffectsVisibleRects
(../../cc/trees/layer_tree_host_impl_unittest.cc:9849)
    LayerTreeHostImplTest.ExternalViewportAffectsVisibleRects
(../../cc/trees/layer_tree_host_impl_unittest.cc:9816)
   
LayerTreeHostPictureTestChangeLiveTilesRectWithRecycleTree.RunMultiThread_DelegatingRenderer
(../../cc/trees/layer_tree_host_unittest_picture.cc:324)
    LayerTreeImplTest.UpdateViewportAndHitTest
(../../cc/trees/layer_tree_impl_unittest.cc:159)
    OcclusionTrackingPictureLayerImplTest.OccludedTilesConsideredDuringEviction
(../../cc/layers/picture_layer_impl_unittest.cc:4136)
    OcclusionTrackingPictureLayerImplTest.OccludedTilesNotMarkedAsRequired
(../../cc/layers/picture_layer_impl_unittest.cc:3849)
   
OcclusionTrackingPictureLayerImplTest.OccludedTilesSkippedDuringRasterization
(../../cc/layers/picture_layer_impl_unittest.cc:3756)
    OcclusionTrackingPictureLayerImplTest.OcclusionForDifferentScales
(../../cc/layers/picture_layer_impl_unittest.cc:3970)
    PictureLayerImplTest.RequiredTilesWithGpuRasterization
(../../cc/layers/picture_layer_impl_unittest.cc:2430)
    PictureLayerImplTest.ScrollPropagatesToPending
(../../cc/layers/picture_layer_impl_unittest.cc:4612)
    PictureLayerImplTest.TilingSetEvictionQueue
(../../cc/layers/picture_layer_impl_unittest.cc:2972)
    PictureLayerImplTest.TilingSetRasterQueue
(../../cc/layers/picture_layer_impl_unittest.cc:2792)
    TileManagerTilePriorityQueueTest.RasterTilePriorityQueueInvalidation
(../../cc/tiles/tile_manager_unittest.cc:449)

Powered by Google App Engine
This is Rietveld 408576698