Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2285343002: In webkitpy/common/net/git_cl.py, print rather than log "waiting" message. (Closed)

Created:
4 years, 3 months ago by qyearsley
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, blink-reviews, Dirk Pranke, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

In webkitpy/common/net/git_cl.py, print rather than log "waiting" message. Reason: In the recent w3c-test-autoroller jobs (e.g. https://build.chromium.org/p/chromium.infra.cron/builders/w3c-test-autoroller/builds/6930), the update wpt step is timing out after 40 minutes with no output after print "Triggering try jobs". I believe that this started happening after http://crrev.com/2265603003, which made it so that when waiting for try job results it uses log.info rather than print. BUG=629275 Committed: https://crrev.com/b6cc4b6ed72adabac176e3acc5a41c048de65e8a Cr-Commit-Position: refs/heads/master@{#415055}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl.py View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
qyearsley
4 years, 3 months ago (2016-08-29 18:04:55 UTC) #2
Dirk Pranke
lgtm
4 years, 3 months ago (2016-08-29 18:07:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2285343002/1
4 years, 3 months ago (2016-08-29 18:26:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 03:45:56 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 03:48:18 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b6cc4b6ed72adabac176e3acc5a41c048de65e8a
Cr-Commit-Position: refs/heads/master@{#415055}

Powered by Google App Engine
This is Rietveld 408576698