Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2285313002:
Removes check on deprecated OfflinePageBridge.isOfflinePagesEnabled() from isNtpOfflinePagesEnabled… (Closed)
|
Created:
4 years, 3 months ago by dougarnett Modified:
4 years, 3 months ago CC:
chromium-reviews, ntp-dev+reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemoves check on deprecated OfflinePageBridge.isOfflinePagesEnabled() from isNtpOfflinePagesEnabled()
BUG=639354
Committed: https://crrev.com/11266087108f0bfbd5818322d432fa2749f37d1c
Cr-Commit-Position: refs/heads/master@{#415405}
Patch Set 1 #
Messages
Total messages: 20 (10 generated)
The CQ bit was checked by dougarnett@chromium.org to run a CQ dry run
dougarnett@chromium.org changed reviewers: + dimich@chromium.org, treib@chromium.org
We are removing this isOfflinePagesEnabled flag (is essence offline pages apis are always now enabled) and just using the NTP flag here should be sufficient to turn on the UX.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/08/29 16:46:25, dougarnett wrote: > We are removing this isOfflinePagesEnabled flag (is essence offline pages apis > are always now enabled) and just using the NTP flag here should be sufficient to > turn on the UX. LGTM from my end
lgtm
The CQ bit was checked by dougarnett@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
dougarnett@chromium.org changed reviewers: + tedchoc@chromium.org
Ted, can you do OWNERS review on this change?
lgtm
The CQ bit was checked by dougarnett@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Removes check on deprecated OfflinePageBridge.isOfflinePagesEnabled() from isNtpOfflinePagesEnabled() BUG=639354 ========== to ========== Removes check on deprecated OfflinePageBridge.isOfflinePagesEnabled() from isNtpOfflinePagesEnabled() BUG=639354 Committed: https://crrev.com/11266087108f0bfbd5818322d432fa2749f37d1c Cr-Commit-Position: refs/heads/master@{#415405} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/11266087108f0bfbd5818322d432fa2749f37d1c Cr-Commit-Position: refs/heads/master@{#415405} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
