Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Unified Diff: runtime/observatory/lib/src/elements/cpu_profile_table.dart

Issue 2285303002: Avoid to updated selection on links click in cpu-profile-table (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/lib/src/elements/cpu_profile_table.dart
diff --git a/runtime/observatory/lib/src/elements/cpu_profile_table.dart b/runtime/observatory/lib/src/elements/cpu_profile_table.dart
index 552de27d40115a60a742ea6ce991949f0df7d25e..d7b09d7d0ad2929ad379a201e1d7098ee5d9f8d9 100644
--- a/runtime/observatory/lib/src/elements/cpu_profile_table.dart
+++ b/runtime/observatory/lib/src/elements/cpu_profile_table.dart
@@ -223,7 +223,10 @@ class CpuProfileTableElement extends HtmlElement implements Renderable {
..text = '0%',
new SpanElement()..classes = const ['name']
];
- element.onClick.listen((_) {
+ element.onClick.listen((e) {
+ if (e.target is AnchorElement) {
+ return;
+ }
_selected = _functions.getItemFromElement(element);
_r.dirty();
});
@@ -287,7 +290,10 @@ class CpuProfileTableElement extends HtmlElement implements Renderable {
..text = '0%',
new SpanElement()..classes = const ['name']
];
- element.onClick.listen((_) {
+ element.onClick.listen((e) {
+ if (e.target is AnchorElement) {
+ return;
+ }
_selected = _callees.getItemFromElement(element);
_r.dirty();
});
@@ -322,7 +328,10 @@ class CpuProfileTableElement extends HtmlElement implements Renderable {
..text = '0%',
new SpanElement()..classes = const ['name']
];
- element.onClick.listen((_) {
+ element.onClick.listen((e) {
+ if (e.target is AnchorElement) {
+ return;
+ }
_selected = _callers.getItemFromElement(element);
_r.dirty();
});
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698