Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: third_party/WebKit/Source/core/dom/Document.cpp

Issue 2285253003: Move TopDocumentRootScrollerController to a separate object on FrameHost (Closed)
Patch Set: None Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/Document.cpp
diff --git a/third_party/WebKit/Source/core/dom/Document.cpp b/third_party/WebKit/Source/core/dom/Document.cpp
index 4f5b5487a41e44be3ab0c5a37125580e3c592af0..f2408ba413d89bf679c0d10c4b881e575d57f2f2 100644
--- a/third_party/WebKit/Source/core/dom/Document.cpp
+++ b/third_party/WebKit/Source/core/dom/Document.cpp
@@ -473,11 +473,7 @@ Document::Document(const DocumentInit& initializer, DocumentClassFlags documentC
m_fetcher = ResourceFetcher::create(nullptr);
}
- // TODO(bokan): This will probably blow up if we don't have an m_frame here
- // since we'll assume a child RootScrollerController. crbug.com/505516.
- m_rootScrollerController = isInMainFrame()
- ? TopDocumentRootScrollerController::create(*this)
- : RootScrollerController::create(*this);
+ m_rootScrollerController = RootScrollerController::create(*this);
// We depend on the url getting immediately set in subframes, but we
// also depend on the url NOT getting immediately set in opened windows.
@@ -2138,9 +2134,6 @@ void Document::attachLayoutTree(const AttachContext& context)
if (view())
view()->didAttachDocument();
-
- // Needs to be called after view()->didAttachDocument().
- m_rootScrollerController->didAttachDocument();
}
void Document::detachLayoutTree(const AttachContext& context)

Powered by Google App Engine
This is Rietveld 408576698