Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp

Issue 2285253003: Move TopDocumentRootScrollerController to a separate object on FrameHost (Closed)
Patch Set: Rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp
diff --git a/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp b/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp
index fae9536ffe05741f0be678b32e314de5fbcf39f6..a1db37e3af6050fca2bffe114d5ac7fa0692a263 100644
--- a/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp
+++ b/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp
@@ -253,7 +253,6 @@ void PaintLayerCompositor::updateIfNeededRecursiveInternal()
scrollableArea->updateCompositorScrollAnimations();
}
- m_layoutView.document().rootScrollerController()->didUpdateCompositing();
#if ENABLE(ASSERT)
ASSERT(lifecycle().state() == DocumentLifecycle::CompositingClean);
assertNoUnresolvedDirtyBits();
@@ -475,15 +474,12 @@ void PaintLayerCompositor::updateClippingOnCompositorLayers()
!RuntimeEnabledFeatures::rootLayerScrollingEnabled() && shouldClip);
}
- // TODO(bokan): Temporary hack-cast to TDRSC until the follow-up patch
- // lands and we can get a pointer to a TopDocumentRootScrollerController
- // legitimately.
- TopDocumentRootScrollerController* globalRootScrollerController =
- (TopDocumentRootScrollerController*)m_layoutView.document().topDocument().rootScrollerController();
+ const TopDocumentRootScrollerController& globalRootScrollerController =
+ m_layoutView.document().frameHost()->globalRootScrollerController();
Element* documentElement = m_layoutView.document().documentElement();
bool frameIsRootScroller = documentElement && documentElement->isSameNode(
- globalRootScrollerController->globalRootScroller());
+ globalRootScrollerController.globalRootScroller());
// We normally clip iframes' (but not the root frame) overflow controls
// host and container layers but if the root scroller is the iframe itself

Powered by Google App Engine
This is Rietveld 408576698