Move TopDocumentRootScrollerController to a separate object on FrameHost

third_party/WebKit/Source/web/tests/RootScrollerTest.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/frame/FrameHost.h"
 #include "core/frame/FrameView.h"
 #include "core/frame/TopControls.h"
 #include "core/html/HTMLFrameOwnerElement.h"
 #include "core/layout/LayoutBox.h"
 #include "core/layout/api/LayoutViewItem.h"
@@ skipping 518 matching lines @@
 {
     // TODO(bokan): The expectation and actual in the checks here are backwards.
     initialize("root-scroller-iframe.html");
     ASSERT_EQ(nullptr, mainFrame()->document()->rootScroller());
 
     HTMLFrameOwnerElement* iframe = toHTMLFrameOwnerElement(
         mainFrame()->document()->getElementById("iframe"));
     Element* container =
         iframe->contentDocument()->getElementById("container");
 
-    RootScrollerController* mainController =
-        mainFrame()->document()->rootScrollerController();
+    const TopDocumentRootScrollerController& mainController =
+        mainFrame()->document()->frameHost()->globalRootScrollerController();
 
     NonThrowableExceptionState nonThrow;
 
     // No root scroller set, the documentElement should be the effective root
     // and the main FrameView's scroll layer should be the layer to use.
     {
         EXPECT_EQ(
-            mainController->rootScrollerLayer(),
+            mainController.rootScrollerLayer(),
             mainFrameView()->layerForScrolling());
-        EXPECT_TRUE(mainController->isViewportScrollCallback(
+        EXPECT_TRUE(mainController.isViewportScrollCallback(
             mainFrame()->document()->documentElement()->getApplyScroll()));
     }
 
     // Set a root scroller in the iframe. Since the main document didn't set a
     // root scroller, the global root scroller shouldn't change.
     {
 
         iframe->contentDocument()->setRootScroller(container, nonThrow);
         mainFrameView()->updateAllLifecyclePhases();
 
         EXPECT_EQ(
-            mainController->rootScrollerLayer(),
+            mainController.rootScrollerLayer(),
             mainFrameView()->layerForScrolling());
-        EXPECT_TRUE(mainController->isViewportScrollCallback(
+        EXPECT_TRUE(mainController.isViewportScrollCallback(
             mainFrame()->document()->documentElement()->getApplyScroll()));
     }
 
     // Setting the iframe as the root scroller in the main frame should now
     // link the root scrollers so the container should now be the global root
     // scroller.
     {
         mainFrame()->document()->setRootScroller(iframe, nonThrow);
         mainFrameView()->updateAllLifecyclePhases();
 
         ScrollableArea* containerScroller =
             static_cast<PaintInvalidationCapableScrollableArea*>(
                 toLayoutBox(container->layoutObject())->getScrollableArea());
 
         EXPECT_EQ(
-            mainController->rootScrollerLayer(),
+            mainController.rootScrollerLayer(),
             containerScroller->layerForScrolling());
-        EXPECT_FALSE(mainController->isViewportScrollCallback(
+        EXPECT_FALSE(mainController.isViewportScrollCallback(
             mainFrame()->document()->documentElement()->getApplyScroll()));
-        EXPECT_TRUE(mainController->isViewportScrollCallback(
+        EXPECT_TRUE(mainController.isViewportScrollCallback(
             container->getApplyScroll()));
     }
 
     // Unsetting the root scroller in the iframe should reset its effective
     // root scroller to the iframe's documentElement and thus the iframe's
     // documentElement becomes the global root scroller.
     {
         iframe->contentDocument()->setRootScroller(nullptr, nonThrow);
         mainFrameView()->updateAllLifecyclePhases();
         EXPECT_EQ(
-            mainController->rootScrollerLayer(),
+            mainController.rootScrollerLayer(),
             iframe->contentDocument()->view()->layerForScrolling());
-        EXPECT_FALSE(mainController->isViewportScrollCallback(
+        EXPECT_FALSE(mainController.isViewportScrollCallback(
             container->getApplyScroll()));
-        EXPECT_FALSE(mainController->isViewportScrollCallback(
+        EXPECT_FALSE(mainController.isViewportScrollCallback(
             mainFrame()->document()->documentElement()->getApplyScroll()));
-        EXPECT_TRUE(mainController->isViewportScrollCallback(
+        EXPECT_TRUE(mainController.isViewportScrollCallback(
             iframe->contentDocument()->documentElement()->getApplyScroll()));
     }
 
     // Finally, unsetting the main frame's root scroller should reset it to the
     // documentElement and corresponding layer.
     {
         mainFrame()->document()->setRootScroller(nullptr, nonThrow);
         mainFrameView()->updateAllLifecyclePhases();
         EXPECT_EQ(
-            mainController->rootScrollerLayer(),
+            mainController.rootScrollerLayer(),
             mainFrameView()->layerForScrolling());
-        EXPECT_TRUE(mainController->isViewportScrollCallback(
+        EXPECT_TRUE(mainController.isViewportScrollCallback(
             mainFrame()->document()->documentElement()->getApplyScroll()));
-        EXPECT_FALSE(mainController->isViewportScrollCallback(
+        EXPECT_FALSE(mainController.isViewportScrollCallback(
             container->getApplyScroll()));
-        EXPECT_FALSE(mainController->isViewportScrollCallback(
+        EXPECT_FALSE(mainController.isViewportScrollCallback(
             iframe->contentDocument()->documentElement()->getApplyScroll()));
     }
 }
 
 TEST_F(RootScrollerTest, TestSetRootScrollerCausesViewportLayerChange)
 {
     // TODO(bokan): Need a test that changing root scrollers actually sets the
     // outer viewport layer on the compositor, even in the absence of other
     // compositing changes. crbug.com/505516
 }
@@ skipping 133 matching lines @@
     }
 
     // Reset explicitly to prevent lifetime issues with the RemoteFrameClient.
     m_helper.reset();
 }
 
 // Tests that clipping layers belonging to any compositors in the ancestor chain
 // of the global root scroller have their masking bit removed.
 TEST_F(RootScrollerTest, RemoveClippingOnCompositorLayers)
 {
-    // TODO(bokan): Remove casts to TDRSC once follow-up patch lands separating TDRSC
-    // from RootScrollerController.
-
     initialize("root-scroller-iframe.html");
 
     HTMLFrameOwnerElement* iframe = toHTMLFrameOwnerElement(
         mainFrame()->document()->getElementById("iframe"));
     Element* container =
         iframe->contentDocument()->getElementById("container");
 
     RootScrollerController* mainController =
         mainFrame()->document()->rootScrollerController();
     RootScrollerController* childController =
         iframe->contentDocument()->rootScrollerController();
+    TopDocumentRootScrollerController& globalController =
+        frameHost().globalRootScrollerController();
 
     PaintLayerCompositor* mainCompositor =
         mainFrameView()->layoutViewItem().compositor();
     PaintLayerCompositor* childCompositor =
         iframe->contentDocument()->view()->layoutViewItem().compositor();
 
     NonThrowableExceptionState nonThrow;
 
     // No root scroller set, on the main frame the root content layer should
     // clip. Additionally, on the child frame, the overflow controls host and
@@ skipping 44 matching lines @@
     // global root scroller we want it to behave as if it were the main frame, which
     // means it should clip only on its root content layer.
     {
         iframe->contentDocument()->setRootScroller(nullptr, nonThrow);
         mainFrameView()->updateAllLifecyclePhases();
 
         ASSERT_EQ(iframe, mainController->effectiveRootScroller());
         ASSERT_EQ(iframe->contentDocument()->documentElement(),
             childController->effectiveRootScroller());
         ASSERT_EQ(iframe->contentDocument()->documentElement(),
-            ((TopDocumentRootScrollerController*)mainController)
-                ->globalRootScroller());
+            globalController.globalRootScroller());
 
         EXPECT_FALSE(mainCompositor->rootContentLayer()->platformLayer()
             ->masksToBounds());
         EXPECT_FALSE(mainCompositor->rootGraphicsLayer()->platformLayer()
             ->masksToBounds());
         EXPECT_FALSE(mainCompositor->containerLayer()->platformLayer()
             ->masksToBounds());
 
         EXPECT_TRUE(childCompositor->rootContentLayer()->platformLayer()
             ->masksToBounds());
@@ skipping 11 matching lines @@
 
     {
         mainFrame()->document()->setRootScroller(nullptr, nonThrow);
         mainFrameView()->updateAllLifecyclePhases();
 
         ASSERT_EQ(mainFrame()->document()->documentElement(),
             mainController->effectiveRootScroller());
         ASSERT_EQ(iframe->contentDocument()->documentElement(),
             childController->effectiveRootScroller());
         ASSERT_EQ(mainFrame()->document()->documentElement(),
-            ((TopDocumentRootScrollerController*)mainController)
-                ->globalRootScroller());
+            globalController.globalRootScroller());
 
         EXPECT_TRUE(mainCompositor->rootContentLayer()->platformLayer()
             ->masksToBounds());
         EXPECT_FALSE(mainCompositor->rootGraphicsLayer()->platformLayer()
             ->masksToBounds());
         EXPECT_FALSE(mainCompositor->containerLayer()->platformLayer()
             ->masksToBounds());
 
         EXPECT_TRUE(childCompositor->rootContentLayer()->platformLayer()
             ->masksToBounds());
         EXPECT_TRUE(childCompositor->rootGraphicsLayer()->platformLayer()
             ->masksToBounds());
         EXPECT_TRUE(childCompositor->containerLayer()->platformLayer()
             ->masksToBounds());
     }
 
     // Set the iframe back as the main frame's root scroller. Since its the
     // global root scroller again, it should clip like the root frame. This
     // checks that we invalidate the compositing state even though the iframe's
     // effective root scroller hasn't changed.
     {
         mainFrame()->document()->setRootScroller(iframe, nonThrow);
         mainFrameView()->updateAllLifecyclePhases();
 
         ASSERT_EQ(iframe, mainController->effectiveRootScroller());
         ASSERT_EQ(iframe->contentDocument()->documentElement(),
             childController->effectiveRootScroller());
         ASSERT_EQ(iframe->contentDocument()->documentElement(),
-            ((TopDocumentRootScrollerController*)mainController)
-                ->globalRootScroller());
+            globalController.globalRootScroller());
 
         EXPECT_FALSE(mainCompositor->rootContentLayer()->platformLayer()
             ->masksToBounds());
         EXPECT_FALSE(mainCompositor->rootGraphicsLayer()->platformLayer()
             ->masksToBounds());
         EXPECT_FALSE(mainCompositor->containerLayer()->platformLayer()
             ->masksToBounds());
 
         EXPECT_TRUE(childCompositor->rootContentLayer()->platformLayer()
             ->masksToBounds());
@@ skipping 26 matching lines @@
         EXPECT_FALSE(childCompositor->rootGraphicsLayer()->platformLayer()
             ->masksToBounds());
         EXPECT_FALSE(childCompositor->containerLayer()->platformLayer()
             ->masksToBounds());
     }
 }
 
 } // namespace
 
 } // namespace blink