Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Side by Side Diff: tests/standalone/io/test_extension_fail_test.dart

Issue 2285223003: Fix native extension lookup (Closed)
Patch Set: Update test for error message change Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/bin/utils_win.cc ('k') | tests/standalone/io/test_relative_extension.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 // 4 //
5 // Dart test program for testing native extensions. 5 // Dart test program for testing native extensions.
6 6
7 import "package:path/path.dart"; 7 import "package:path/path.dart";
8 import "dart:async"; 8 import "dart:async";
9 import "dart:io"; 9 import "dart:io";
10 10
(...skipping 17 matching lines...) Expand all
28 case 'macos': 28 case 'macos':
29 return join(buildDirectory, 'libtest_extension.dylib'); 29 return join(buildDirectory, 'libtest_extension.dylib');
30 case 'windows': 30 case 'windows':
31 return join(buildDirectory, 'test_extension.dll'); 31 return join(buildDirectory, 'test_extension.dll');
32 default: 32 default:
33 throw new StateError( 33 throw new StateError(
34 'Unknown operating system ${Platform.operatingSystem}'); 34 'Unknown operating system ${Platform.operatingSystem}');
35 } 35 }
36 } 36 }
37 37
38 void main() { 38 bool checkExitCode(int code) {
39 return ((code == 255) || (code == 253));
40 }
41
42 bool checkStdError(String err) {
43 return err.contains("Unhandled exception:") ||
44 err.contains(
45 "Native extension path must be absolute, or simply the file name");
46 }
47
48 // name is either "extension" or "relative_extension"
49 Future test(String name, bool checkForBall) {
39 String scriptDirectory = dirname(Platform.script.toFilePath()); 50 String scriptDirectory = dirname(Platform.script.toFilePath());
40 String buildDirectory = dirname(Platform.executable); 51 String buildDirectory = dirname(Platform.executable);
41 Directory tempDirectory = 52 Directory tempDirectory =
42 Directory.systemTemp.createTempSync('dart_test_extension_fail'); 53 Directory.systemTemp.createTempSync('dart_test_${name}_fail');
43 String testDirectory = tempDirectory.path; 54 String testDirectory = tempDirectory.path;
44 55
45 // Copy test_extension shared library, test_extension.dart and 56 // Copy test_extension shared library, test_extension.dart and
46 // test_extension_fail_tester.dart to the temporary test directory. 57 // test_extension_fail_tester.dart to the temporary test directory.
47 copyFileToDirectory(getExtensionPath(buildDirectory), 58 copyFileToDirectory(getExtensionPath(buildDirectory),
48 testDirectory).then((_) { 59 testDirectory).then((_) {
49 var extensionDartFile = join(scriptDirectory, 'test_extension.dart'); 60 var extensionDartFile = join(scriptDirectory, 'test_${name}.dart');
50 return copyFileToDirectory(extensionDartFile, testDirectory); 61 return copyFileToDirectory(extensionDartFile, testDirectory);
51 }).then((_) { 62 }).then((_) {
52 var testExtensionTesterFile = 63 var testExtensionTesterFile =
53 join(scriptDirectory, 'test_extension_fail_tester.dart'); 64 join(scriptDirectory, 'test_${name}_fail_tester.dart');
54 return copyFileToDirectory(testExtensionTesterFile, testDirectory); 65 return copyFileToDirectory(testExtensionTesterFile, testDirectory);
55 }).then((_) { 66 }).then((_) {
56 var script = join(testDirectory, 'test_extension_fail_tester.dart'); 67 var script = join(testDirectory, 'test_${name}_fail_tester.dart');
57 return Process.run(Platform.executable, [script]); 68 return Process.run(Platform.executable, ['--trace-loading', script]);
58 }).then((ProcessResult result) { 69 }).then((ProcessResult result) {
59 print("ERR: ${result.stderr}\n\n"); 70 print("ERR: ${result.stderr}\n\n");
60 print("OUT: ${result.stdout}\n\n"); 71 print("OUT: ${result.stdout}\n\n");
61 if (result.exitCode != 255) { 72 if (!checkExitCode(result.exitCode)) {
62 throw new StateError("bad exit code"); 73 throw new StateError("bad exit code: ${result.exitCode}");
63 } 74 }
64 if (!result.stderr.contains("Unhandled exception:")) { 75 if (!checkStdError(result.stderr)) {
65 throw new StateError("stderr doesn't contain unhandled exception."); 76 throw new StateError("stderr doesn't contain unhandled exception.");
66 } 77 }
67 if (!result.stderr.contains("ball")) { 78 if (checkForBall) {
68 throw new StateError("stderr doesn't contain 'ball'."); 79 if (!result.stderr.contains("ball")) {
80 throw new StateError("stderr doesn't contain 'ball'.");
81 }
69 } 82 }
70 }).whenComplete(() => tempDirectory.deleteSync(recursive: true)); 83 }).whenComplete(() => tempDirectory.deleteSync(recursive: true));
71 } 84 }
85
86 main() async {
87 await test("extension", true);
88 await test("relative_extension", false);
89 }
OLDNEW
« no previous file with comments | « runtime/bin/utils_win.cc ('k') | tests/standalone/io/test_relative_extension.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698