Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Unified Diff: src/assembler.cc

Issue 2285223002: [wasm] Do not check load/store offsets with DCHECK. (Closed)
Patch Set: Add comment Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/assembler.cc
diff --git a/src/assembler.cc b/src/assembler.cc
index 83dbbe813409944fcb809c3db777a4d89d7195fa..f90a0a2ee5b7fe2292f0aeae5b0eb479f30d9796 100644
--- a/src/assembler.cc
+++ b/src/assembler.cc
@@ -350,11 +350,9 @@ void RelocInfo::update_wasm_memory_reference(
DCHECK(IsWasmMemoryReference(rmode_) || IsWasmMemorySizeReference(rmode_));
if (IsWasmMemoryReference(rmode_)) {
Address updated_reference;
- DCHECK(old_size == 0 || Memory::IsAddressInRange(
- old_base, wasm_memory_reference(), old_size));
updated_reference = new_base + (wasm_memory_reference() - old_base);
- DCHECK(new_size == 0 ||
- Memory::IsAddressInRange(new_base, updated_reference, new_size));
+ // The reference is not checked here but at runtime. Validity of references
+ // may change over time.
unchecked_update_wasm_memory_reference(updated_reference,
icache_flush_mode);
} else if (IsWasmMemorySizeReference(rmode_)) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698