[wasm] Do not check load/store offsets with DCHECK.

[wasm] Do not check load/store offsets with DCHECK.

These DCHECKs are executed when a wasm module is instantiated. However,
invalid load/store offsets should trigger runtime traps, not
instantiation-time errors.

R=titzer@chromium.org

Committed: https://crrev.com/eaa3573ad52025afde9af1f41f96e48d41159b9a
Cr-Commit-Position: refs/heads/master@{#38981}

[ahaas, 2016-08-29 12:04:22]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-29 12:04:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[titzer, 2016-08-29 12:19:18]

lgtm

https://codereview.chromium.org/2285223002/diff/1/src/assembler.cc
File src/assembler.cc (left):

https://codereview.chromium.org/2285223002/diff/1/src/assembler.cc#oldcode354
src/assembler.cc:354: old_base, wasm_memory_reference(), old_size));
Wanna add a comment here as to why references can be out of bounds?

[commit-bot: I haz the power, 2016-08-29 12:34:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-29 12:34:28]

Dry run: This issue passed the CQ dry run.

[ahaas, 2016-08-29 12:53:21]

https://codereview.chromium.org/2285223002/diff/1/src/assembler.cc
File src/assembler.cc (left):

https://codereview.chromium.org/2285223002/diff/1/src/assembler.cc#oldcode354
src/assembler.cc:354: old_base, wasm_memory_reference(), old_size));
On 2016/08/29 at 12:19:18, titzer wrote:
> Wanna add a comment here as to why references can be out of bounds?

Done.

[ahaas, 2016-08-29 12:53:27]

The CQ bit was checked by ahaas@chromium.org

[ahaas, 2016-08-29 12:53:27]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/2285223002/#ps20001
(title: "Add comment")

[commit-bot: I haz the power, 2016-08-29 12:53:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-29 13:20:29]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-29 13:20:40]

Description was changed from

==========
[wasm] Do not check load/store offsets with DCHECK.

These DCHECKs are executed when a wasm module is instantiated. However,
invalid load/store offsets should trigger runtime traps, not
instantiation-time errors.

R=titzer@chromium.org
==========

to

==========
[wasm] Do not check load/store offsets with DCHECK.

These DCHECKs are executed when a wasm module is instantiated. However,
invalid load/store offsets should trigger runtime traps, not
instantiation-time errors.

R=titzer@chromium.org

Committed: https://crrev.com/eaa3573ad52025afde9af1f41f96e48d41159b9a
Cr-Commit-Position: refs/heads/master@{#38981}
==========

[commit-bot: I haz the power, 2016-08-29 13:20:41]

Patchset 2 (id:??) landed as
https://crrev.com/eaa3573ad52025afde9af1f41f96e48d41159b9a
Cr-Commit-Position: refs/heads/master@{#38981}