Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Unified Diff: test/cctest/cctest.h

Issue 22852024: Track JS allocations as they arrive with no affection on performance when tracking is switched off (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Make separate API for JS allocations recording, add example of checking JS allocations recording in… Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/cctest.h
diff --git a/test/cctest/cctest.h b/test/cctest/cctest.h
index 193126a0818e91a1aac21a900c0b0db476c7467d..0efcf066b7bb11dd2065b30329a8496ccf51a16a 100644
--- a/test/cctest/cctest.h
+++ b/test/cctest/cctest.h
@@ -71,6 +71,17 @@ typedef v8::internal::EnumSet<CcTestExtensionIds> CcTestExtensionFlags;
EXTENSION_LIST(DEFINE_EXTENSION_FLAG)
#undef DEFINE_EXTENSION_FLAG
+void RunAndTrackAllocations(void (*test)());
+
+#ifndef TEST_TRACK_ALLOCATIONS
+#define TEST_TRACK_ALLOCATIONS(Name) \
+ static void Test##Name(); \
+ TEST(Name##TrackAllocations) { \
+ RunAndTrackAllocations(&Test##Name); \
+ } \
+ TEST(Name)
+#endif
+
class CcTest {
public:
typedef void (TestFunction)();
@@ -300,4 +311,41 @@ static inline void SimulateFullSpace(v8::internal::PagedSpace* space) {
}
+// Helper class for new allocations tracking and checking.
+// To use checking of JS allocations tracking in a test,
+// use TEST_TRACK_ALLOCATIONS macro or just create an instance
+// of this class.
+class HeapObjectsTracker {
+ public:
+ HeapObjectsTracker() {
+ heap_profiler_ = i::Isolate::Current()->heap_profiler();
+ CHECK_NE(NULL, heap_profiler_);
+
+ heap_profiler_->StartHeapAllocationsRecording();
+
+ HEAP->CollectAllAvailableGarbage();
+ HEAP->CollectAllAvailableGarbage();
+ HEAP->CollectAllAvailableGarbage();
+ untracked_on_start_ = heap_profiler_->FindUntrackedObjects();
+ }
+
+ virtual ~HeapObjectsTracker() {
+ CHECK_GE(0, CountUntrackedObjects());
+ heap_profiler_->StopHeapAllocationsRecording();
+ }
+
+ private:
+ int CountUntrackedObjects() {
+ HEAP->CollectAllAvailableGarbage();
+ HEAP->CollectAllAvailableGarbage();
+ HEAP->CollectAllAvailableGarbage();
+
+ return heap_profiler_->FindUntrackedObjects() - untracked_on_start_;
+ }
+
+ i::HeapProfiler* heap_profiler_;
+ int untracked_on_start_;
+};
+
+
#endif // ifndef CCTEST_H_

Powered by Google App Engine
This is Rietveld 408576698