Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Unified Diff: test/cctest/test-heap.cc

Issue 22852024: Track JS allocations as they arrive with no affection on performance when tracking is switched off (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Fix tracking flag + encode allocation type instead of calling different methods Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/test-heap.cc
diff --git a/test/cctest/test-heap.cc b/test/cctest/test-heap.cc
index 2824d5b242465f2784656c386938750df435ac67..7eed7f8e877728798a2f4440165c1313a9363eb4 100644
--- a/test/cctest/test-heap.cc
+++ b/test/cctest/test-heap.cc
@@ -3229,6 +3229,8 @@ TEST(Regress169928) {
Factory* factory = isolate->factory();
v8::HandleScope scope(CcTest::isolate());
+ HeapObjectsTracker tracker;
+
// Some flags turn Scavenge collections into Mark-sweep collections
// and hence are incompatible with this test case.
if (FLAG_gc_global || FLAG_stress_compaction) return;
@@ -3252,7 +3254,6 @@ TEST(Regress169928) {
v8::Local<v8::String> array_name = v8_str("mote");
v8::Context::GetCurrent()->Global()->Set(array_name, v8::Int32::New(0));
-
yurys 2013/09/25 10:41:12 Revert this.
Alexandra Mikhaylova 2013/09/25 14:33:40 Done.
// First make sure we flip spaces
CcTest::heap()->CollectGarbage(NEW_SPACE);

Powered by Google App Engine
This is Rietveld 408576698