Track JS allocations as they arrive with no affection on performance when tracking is switched off

src/objects.cc

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 2294 matching lines @@
   elms->set_length(len - to_trim);
 
   // Maintain marking consistency for IncrementalMarking.
   if (Marking::IsBlack(Marking::MarkBitFrom(elms))) {
     if (trim_mode == FROM_GC) {
       MemoryChunk::IncrementLiveBytesFromGC(elms->address(), -size_delta);
     } else {
       MemoryChunk::IncrementLiveBytesFromMutator(elms->address(), -size_delta);
     }
   }
+
+  // This repeating record is necessary because the array may not be moved
+  // during GC, and size has to be adjusted nevetheless.

[loislo, 2013/08/27 09:04:57]

tipo: nevertheless

[Alexandra Mikhaylova, 2013/09/19 16:03:38]

Done.

+  HeapProfiler* profiler = heap->isolate()->heap_profiler();
+  if (profiler->is_tracking_allocations()) {
+    profiler->NewObjectEvent(elms->address(), elms->Size());

[loislo, 2013/08/27 09:04:57]

Sounds like we need UpdateObjectSizeEvent method.

[Hannes Payer (out of office), 2013/08/28 09:51:32]

yes, an update object size event would be the right thing here.

[Alexandra Mikhaylova, 2013/09/19 16:03:38]

Done.

[Alexandra Mikhaylova, 2013/09/19 16:03:38]

Done.

+  }
 }
 
 
 bool Map::InstancesNeedRewriting(Map* target,
                                  int target_number_of_fields,
                                  int target_inobject,
                                  int target_unused) {
   // If fields were added (or removed), rewrite the instance.
   int number_of_fields = NumberOfFields();
   ASSERT(target_number_of_fields >= number_of_fields);
@@ skipping 13627 matching lines @@
 #define ERROR_MESSAGES_TEXTS(C, T) T,
   static const char* error_messages_[] = {
       ERROR_MESSAGES_LIST(ERROR_MESSAGES_TEXTS)
   };
 #undef ERROR_MESSAGES_TEXTS
   return error_messages_[reason];
 }
 
 
 } }  // namespace v8::internal