tools/grokdump.py - Issue 22852021: grokdump: fix Oddball printing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/grokdump.py

Issue 22852021: grokdump: fix Oddball printing (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/grokdump.py

diff --git a/tools/grokdump.py b/tools/grokdump.py

index 12ccefdef74b6aa3b72ed01ce63634cc553c0bde..317a7d6a911fe4dd0bd0014af19bdde1585c3770 100755

--- a/tools/grokdump.py

+++ b/tools/grokdump.py

@@ -1138,7 +1138,7 @@ class Oddball(HeapObject):

def __str__(self):

if self.to_string:

- return "Oddball(%08x, <%s>)" % (self.address, self.to_string.GetChars())

+ return "Oddball(%08x, <%s>)" % (self.address, str(self.to_string))

else:

kind = "???"

if 0 <= self.kind < len(Oddball.KINDS):

« no previous file with comments | « no previous file | no next file » | no next file with comments »