Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(759)

Unified Diff: pkg/barback/test/package_graph/transform_test.dart

Issue 22852007: Fix a pass-through bug in barback. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/barback/lib/src/phase.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/barback/test/package_graph/transform_test.dart
diff --git a/pkg/barback/test/package_graph/transform_test.dart b/pkg/barback/test/package_graph/transform_test.dart
index f7d712d3f56b733ef6d74130caeb92d16b827dd6..4d7b97e7ed6217bb3cac2508be575a40c0f1c3d2 100644
--- a/pkg/barback/test/package_graph/transform_test.dart
+++ b/pkg/barback/test/package_graph/transform_test.dart
@@ -919,6 +919,26 @@ main() {
expectAsset("app|foo.mid", "bar.mid.phase2");
buildShouldSucceed();
});
+
+ test("doesn't pass an asset through if it's removed during isPrimary", () {
+ var check = new CheckContentTransformer("bar", " modified");
+ initGraph(["app|foo.txt"], {"app": [[check]]});
+
+ updateSources(["app|foo.txt"]);
+ expectAsset("app|foo.txt", "foo");
+ buildShouldSucceed();
+
+ check.pauseIsPrimary("app|foo.txt");
+ modifyAsset("app|foo.txt", "bar");
+ updateSources(["app|foo.txt"]);
+ // Ensure we're waiting on [check.isPrimary]
+ schedule(pumpEventQueue);
+
+ removeSources(["app|foo.txt"]);
+ check.resumeIsPrimary("app|foo.txt");
+ expectNoAsset("app|foo.txt");
+ buildShouldSucceed();
+ });
});
group('cross-package transforms', () {
« no previous file with comments | « pkg/barback/lib/src/phase.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698