Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2285183002: [turbofan] Lazy bailout for calls doesn't need callee. (Closed)

Created:
4 years, 3 months ago by Benedikt Meurer
Modified:
4 years, 3 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Lazy bailout for calls doesn't need callee. There's no need to preserve the exact callee for lazy bailouts from JSCallFunction in the AstGraphBuilder, as fullcodegen code will never look at that value after the callee returns. So we just push optimized_out instead. BUG=v8:5267 R=jarin@chromium.org Committed: https://crrev.com/f676db4655ea8d87e5f6a8172341dbf0cb09923b Cr-Commit-Position: refs/heads/master@{#38963}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M src/compiler/ast-graph-builder.cc View 1 chunk +4 lines, -1 line 0 comments Download
M test/cctest/cctest.status View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Benedikt Meurer
4 years, 3 months ago (2016-08-29 04:55:38 UTC) #1
Jarin
lgtm
4 years, 3 months ago (2016-08-29 04:58:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2285183002/1
4 years, 3 months ago (2016-08-29 05:03:10 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-29 05:16:13 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-08-29 05:16:38 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f676db4655ea8d87e5f6a8172341dbf0cb09923b
Cr-Commit-Position: refs/heads/master@{#38963}

Powered by Google App Engine
This is Rietveld 408576698