Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2285153003:
Force build request merging on chromium.fyi (Closed)
DescriptionForce build request merging on chromium.fyi
BUG=642109
Committed: https://chromium.googlesource.com/chromium/tools/build/+/b39aff84910b1b3f143099eb03d6ee39f93addab
Patch Set 1 #
Messages
Total messages: 22 (13 generated)
The CQ bit was checked by smut@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/30f184a57d751310)
Patchset #1 (id:1) has been deleted
The CQ bit was checked by smut@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
smut@google.com changed reviewers: + dpranke@google.com, msw@chromium.org
This is supposed to be the default and none of the other chromium.fyi builders are having this problem, but I'm trying it anyways.
Thanks for your help! I'll defer to Dirk for review.
dpranke@chromium.org changed reviewers: + dpranke@chromium.org
If this works, I'll be troubled, but it seems like it can't hurt. lgtm. When was the last time the master was restarted?
On 2016/08/30 01:15:11, Dirk Pranke wrote: > If this works, I'll be troubled, but it seems like it can't hurt. > > lgtm. > > When was the last time the master was restarted? Dunno, but gonna restart it once this lands.
The CQ bit was checked by smut@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Force build request merging on chromium.fyi BUG=642109 ========== to ========== Force build request merging on chromium.fyi BUG=642109 Committed: https://chromium.googlesource.com/chromium/tools/build/+/b39aff84910b1b3f1430... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as https://chromium.googlesource.com/chromium/tools/build/+/b39aff84910b1b3f1430...
Message was sent while issue was closed.
On 2016/08/30 01:15:11, Dirk Pranke wrote: > If this works, I'll be troubled, but it seems like it can't hurt. Hey Dirk, this seems to have worked... what's the concern/followup? As smut@ said in http://crbug.com/642109#c6: "First build after the mergeRequests change and master restart merged thousands of revisions down into one build, jumping ahead to the latest revision" The preceding build was grabbing code from Aug 1: https://build.chromium.org/p/chromium.fyi/builders/Mojo%20ChromiumOS/builds/4062 The subsequent build grabbed source from Aug 29: https://build.chromium.org/p/chromium.fyi/builders/Mojo%20ChromiumOS/builds/4063
Message was sent while issue was closed.
On 2016/08/30 18:18:43, msw wrote: > On 2016/08/30 01:15:11, Dirk Pranke wrote: > > If this works, I'll be troubled, but it seems like it can't hurt. > > Hey Dirk, this seems to have worked... what's the concern/followup? Figure out why that line was needed (if it was), because it shouldn't have been.
Message was sent while issue was closed.
On 2016/08/30 18:28:17, Dirk Pranke wrote: > On 2016/08/30 18:18:43, msw wrote: > > On 2016/08/30 01:15:11, Dirk Pranke wrote: > > > If this works, I'll be troubled, but it seems like it can't hurt. > > > > Hey Dirk, this seems to have worked... what's the concern/followup? > > Figure out why that line was needed (if it was), because it shouldn't have been. Filed http://crbug.com/642459 BuildmasterConfig should use build request merging by default. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
