Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Unified Diff: src/core/SkShadowShader.h

Issue 2285133002: Optimizations and more documentation of SkShadowShader (Closed) Base URL: https://skia.googlesource.com/skia@master
Patch Set: made req changes Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « samplecode/SampleShadowing.cpp ('k') | src/core/SkShadowShader.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/core/SkShadowShader.h
diff --git a/src/core/SkShadowShader.h b/src/core/SkShadowShader.h
index 3263950a93910691b6fd985256a7d0b81d8107f0..ea05ccae89d63cb718a9c4a5912bb3ed85b833b3 100644
--- a/src/core/SkShadowShader.h
+++ b/src/core/SkShadowShader.h
@@ -19,6 +19,9 @@ public:
/** This shader combines the diffuse color in 'diffuseShader' with the shadows
* determined by the 'povDepthShader' and the shadow maps stored in each of the
* lights in 'lights'
+ *
+ * Please note that the shadow shader is required to be in Stage0, otherwise
+ * the texture coords will be wrong within the shader.
*/
static sk_sp<SkShader> Make(sk_sp<SkShader> povDepthShader,
sk_sp<SkShader> diffuseShader,
« no previous file with comments | « samplecode/SampleShadowing.cpp ('k') | src/core/SkShadowShader.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698