Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Unified Diff: samplecode/SampleShadowing.cpp

Issue 2285133002: Optimizations and more documentation of SkShadowShader (Closed) Base URL: https://skia.googlesource.com/skia@master
Patch Set: removed redundant vec2 ing Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/core/SkShadowShader.cpp » ('j') | src/core/SkShadowShader.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: samplecode/SampleShadowing.cpp
diff --git a/samplecode/SampleShadowing.cpp b/samplecode/SampleShadowing.cpp
index 4892f9c27df5c97eb27bd38175a2f59ac5082aac..529a6dd7cd15178ad77997e3fd87197d4902c5f3 100644
--- a/samplecode/SampleShadowing.cpp
+++ b/samplecode/SampleShadowing.cpp
@@ -53,7 +53,7 @@ public:
fShadowParams.fShadowRadius = 4.0f;
fShadowParams.fBiasingConstant = 0.3f;
- fShadowParams.fMinVariance = 1024;
+ fShadowParams.fMinVariance = 0.015625;
jvanverth1 2016/08/29 18:30:14 It's not clear to me why this is now 1/64.
vjiaoblack 2016/08/29 19:45:21 I'll put the tranform in later. It was because I
fShadowParams.fType = SkShadowParams::kVariance_ShadowType;
}
« no previous file with comments | « no previous file | src/core/SkShadowShader.cpp » ('j') | src/core/SkShadowShader.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698