Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2285113002: Reland of Fix compiler warnings on "make android_arm" (Closed)

Created:
4 years, 3 months ago by Michael Hablich
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com, Michael Achenbach
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of Fix compiler warnings on "make android_arm" (patchset #1 id:1 of https://codereview.chromium.org/2286163002/ ) Reason for revert: Roll was unstuck before the revert landed => reland Original issue's description: > Revert of Fix compiler warnings on "make android_arm" (patchset #1 id:1 of https://codereview.chromium.org/2264283007/ ) > > Reason for revert: > Speculative revert because of roll blocker https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20debug/builds/2241 > > Original issue's description: > > Fix compiler warnings on "make android_arm" > > > > Committed: https://crrev.com/3e809a6129d0097529c885579ac46e4acf4e99f6 > > Cr-Commit-Position: refs/heads/master@{#38937} > > TBR=bmeurer@chromium.org,jkummerow@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > > Committed: https://crrev.com/d992c1f52f116930239ed90cc033442047e789b4 > Cr-Commit-Position: refs/heads/master@{#38961} TBR=bmeurer@chromium.org,jkummerow@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/4f8e0fa685aa6bc3e694ba4e7c7d3701e0bc1391 Cr-Commit-Position: refs/heads/master@{#38962}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -8 lines) Patch
M gypfiles/standalone.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/js-operator.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/compiler/js-operator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/deoptimize-reason.h View 1 chunk +1 line, -1 line 0 comments Download
M src/deoptimize-reason.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/globals.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Michael Hablich
Created Reland of Fix compiler warnings on "make android_arm"
4 years, 3 months ago (2016-08-28 21:02:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2285113002/1
4 years, 3 months ago (2016-08-28 21:03:02 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-28 21:03:11 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4f8e0fa685aa6bc3e694ba4e7c7d3701e0bc1391 Cr-Commit-Position: refs/heads/master@{#38962}
4 years, 3 months ago (2016-08-28 21:03:40 UTC) #6
Michael Achenbach
4 years, 3 months ago (2016-08-29 09:55:04 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698