Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 22851009: Allow both "--no<flag>" and "--no-<flag>" to disable <flag>. (Closed)

Created:
7 years, 4 months ago by Yang
Modified:
7 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

Allow both "--no<flag>" and "--no-<flag>" to disable <flag>. We shouldn't need to know whether to use --no or --no- as prefix. The latter is more intuitive and also what chromium uses. R=machenbach@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=16261

Patch Set 1 #

Patch Set 2 : also allow --no_ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M src/flags.cc View 1 3 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
7 years, 4 months ago (2013-08-21 11:29:07 UTC) #1
Michael Achenbach
LGTM
7 years, 4 months ago (2013-08-21 14:40:12 UTC) #2
Yang
Committed patchset #2 manually as r16261.
7 years, 4 months ago (2013-08-21 15:17:31 UTC) #3
Michael Starzinger
7 years, 4 months ago (2013-08-21 18:54:23 UTC) #4
Message was sent while issue was closed.
I strongly support this change!

Powered by Google App Engine
This is Rietveld 408576698