Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 2285043002: [ios] Use args destructuring in Mojo test promise. (Closed)

Created:
4 years, 3 months ago by Eugene But (OOO till 7-30)
Modified:
4 years, 3 months ago
Reviewers:
dpapad
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Use args destructuring in Mojo test promise. BUG=None Committed: https://crrev.com/a62168c59e1595a10507027ea0a34e474fa514a3 Cr-Commit-Position: refs/heads/master@{#419256}

Patch Set 1 #

Patch Set 2 : Self review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M ios/web/test/data/mojo_test.js View 1 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Eugene But (OOO till 7-30)
Took EcmaScript6 class and liked args destructuring :)
4 years, 3 months ago (2016-08-27 18:54:21 UTC) #2
Eugene But (OOO till 7-30)
Demetrios?
4 years, 3 months ago (2016-09-16 17:57:41 UTC) #7
dpapad
LGTM. Sorry for the delay. @dbeam: Is it OK to use such assignments in WebUI's ...
4 years, 3 months ago (2016-09-16 18:01:36 UTC) #8
Dan Beam
On 2016/09/16 18:01:36, dpapad wrote: > LGTM. Sorry for the delay. > > @dbeam: Is ...
4 years, 3 months ago (2016-09-16 18:46:40 UTC) #9
Eugene But (OOO till 7-30)
On 2016/09/16 18:46:40, Dan Beam wrote: > On 2016/09/16 18:01:36, dpapad wrote: > > LGTM. ...
4 years, 3 months ago (2016-09-16 18:56:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2285043002/20001
4 years, 3 months ago (2016-09-16 18:56:42 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-16 19:48:45 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 19:51:44 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a62168c59e1595a10507027ea0a34e474fa514a3
Cr-Commit-Position: refs/heads/master@{#419256}

Powered by Google App Engine
This is Rietveld 408576698