Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2285013003: No longer calling DeferredTextureImageUsageParams' default ctor. (Closed)

Created:
4 years, 3 months ago by cblume
Modified:
4 years, 3 months ago
Reviewers:
ericrk
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

No longer calling DeferredTextureImageUsageParams' default ctor. I want to remove SkImage::DeferredTextureImageUsageParams' default ctor. Before I make that change in Skia, I want to update Chrome to no longer call it. The default ctor did not initialize all of the members, which lead to surprises. We could simply initialize all the values to some weird state. But a better option would be to not allow the object to be created unless it can be in a valid state. BUG=2242883004 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/7cba2b534ca68449549d7e3a1113c47dd00ec330 Cr-Commit-Position: refs/heads/master@{#415190}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -15 lines) Patch
M cc/tiles/gpu_image_decode_controller.cc View 3 chunks +5 lines, -15 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
cblume
PTAL
4 years, 3 months ago (2016-08-27 07:02:18 UTC) #7
ericrk
lgtm
4 years, 3 months ago (2016-08-29 19:39:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2285013003/1
4 years, 3 months ago (2016-08-29 20:19:40 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 05:58:43 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 06:01:19 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7cba2b534ca68449549d7e3a1113c47dd00ec330
Cr-Commit-Position: refs/heads/master@{#415190}

Powered by Google App Engine
This is Rietveld 408576698