Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2285003002: Remove a lot of no-longer-used functionality from DecoratedTextfield. (Closed)

Created:
4 years, 3 months ago by Evan Stade
Modified:
4 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, yusukes+watch_chromium.org, rouslan+autofill_chromium.org, tfarina, shuchen+watch_chromium.org, jdonnelly+autofillwatch_chromium.org, nona+watch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove a lot of no-longer-used functionality from DecoratedTextfield. BUG=none Committed: https://crrev.com/c5ae9700a8fbd97808c271f1fa6362a50a73c6ea Cr-Commit-Position: refs/heads/master@{#415184}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -159 lines) Patch
M chrome/browser/ui/views/autofill/decorated_textfield.h View 3 chunks +3 lines, -38 lines 0 comments Download
M chrome/browser/ui/views/autofill/decorated_textfield.cc View 3 chunks +1 line, -120 lines 0 comments Download
M ui/views/controls/textfield/textfield.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
Evan Stade
4 years, 3 months ago (2016-08-29 17:38:17 UTC) #6
sky
LGTM
4 years, 3 months ago (2016-08-29 17:47:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2285003002/1
4 years, 3 months ago (2016-08-29 19:15:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2285003002/1
4 years, 3 months ago (2016-08-30 00:29:08 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 05:53:11 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 05:54:43 UTC) #15
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c5ae9700a8fbd97808c271f1fa6362a50a73c6ea
Cr-Commit-Position: refs/heads/master@{#415184}

Powered by Google App Engine
This is Rietveld 408576698