Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 22850002: Make DataTransferItemList indexed getter anonymous (Closed)

Created:
7 years, 4 months ago by do-not-use
Modified:
7 years, 4 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org, do-not-use, lgombos
Visibility:
Public.

Description

Make DataTransferItemList indexed getter anonymous Make DataTransferItemList indexed getter anonymous to match the latest specification: http://www.whatwg.org/specs/web-apps/current-work/multipage/dnd.html#datatransferitemlist DataTransferItemList is not implemented in Firefox 23 or IE10. The compatibility risk is low since developers usually use the [] operator instead. BUG=271424 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156027

Patch Set 1 #

Total comments: 5

Patch Set 2 : Fix nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -69 lines) Patch
M LayoutTests/fast/events/clipboard-dataTransferItemList.html View 1 6 chunks +37 lines, -46 lines 0 comments Download
M LayoutTests/fast/events/clipboard-dataTransferItemList-expected.txt View 1 1 chunk +40 lines, -22 lines 0 comments Download
M Source/core/dom/DataTransferItemList.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
do-not-use
7 years, 4 months ago (2013-08-12 14:29:59 UTC) #1
arv (Not doing code reviews)
LGTM
7 years, 4 months ago (2013-08-12 15:15:48 UTC) #2
haraken
LGTM. Needs an approval from an API owner. https://codereview.chromium.org/22850002/diff/1/LayoutTests/fast/events/clipboard-dataTransferItemList.html File LayoutTests/fast/events/clipboard-dataTransferItemList.html (right): https://codereview.chromium.org/22850002/diff/1/LayoutTests/fast/events/clipboard-dataTransferItemList.html#newcode76 LayoutTests/fast/events/clipboard-dataTransferItemList.html:76: function ...
7 years, 4 months ago (2013-08-12 15:44:43 UTC) #3
haraken
https://codereview.chromium.org/22850002/diff/1/LayoutTests/fast/events/clipboard-dataTransferItemList.html File LayoutTests/fast/events/clipboard-dataTransferItemList.html (right): https://codereview.chromium.org/22850002/diff/1/LayoutTests/fast/events/clipboard-dataTransferItemList.html#newcode142 LayoutTests/fast/events/clipboard-dataTransferItemList.html:142: <div id="console"></div> On 2013/08/12 15:44:43, haraken wrote: > > ...
7 years, 4 months ago (2013-08-12 15:46:12 UTC) #4
arv (Not doing code reviews)
https://codereview.chromium.org/22850002/diff/1/LayoutTests/fast/events/clipboard-dataTransferItemList.html File LayoutTests/fast/events/clipboard-dataTransferItemList.html (right): https://codereview.chromium.org/22850002/diff/1/LayoutTests/fast/events/clipboard-dataTransferItemList.html#newcode142 LayoutTests/fast/events/clipboard-dataTransferItemList.html:142: <div id="console"></div> On 2013/08/12 15:44:43, haraken wrote: > > ...
7 years, 4 months ago (2013-08-12 15:46:38 UTC) #5
do-not-use
+jochen
7 years, 4 months ago (2013-08-13 10:49:44 UTC) #6
jochen (gone - plz use gerrit)
lgtm
7 years, 4 months ago (2013-08-13 13:58:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/22850002/8001
7 years, 4 months ago (2013-08-13 13:59:35 UTC) #8
commit-bot: I haz the power
7 years, 4 months ago (2013-08-13 15:57:16 UTC) #9
Message was sent while issue was closed.
Change committed as 156027

Powered by Google App Engine
This is Rietveld 408576698