Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2284973002: Skia recipe: Use [depot_tools]/gsutil.py instead of [depot_tools]/third_party/gsutil/gsutil (Closed)

Created:
4 years, 3 months ago by Ryan Tseng
Modified:
4 years, 3 months ago
Reviewers:
borenet, rmistry, hinoka
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Skia recipe: Use [depot_tools]/gsutil.py instead of [depot_tools]/third_party/gsutil/gsutil The latter is being removed in https://codereview.chromium.org/2280023003/ Is also pinned to 3.25, whereas the former is updated more often. BUG= Committed: https://chromium.googlesource.com/chromium/tools/build/+/be52565c2553c03b801f4bfc080c7ebc63b550fa

Patch Set 1 #

Patch Set 2 : Rebase #

Messages

Total messages: 18 (11 generated)
hinoka
ptal!
4 years, 3 months ago (2016-08-26 23:01:57 UTC) #4
Ryan Tseng
Rebase
4 years, 3 months ago (2016-08-26 23:07:03 UTC) #7
borenet
LGTM, but these have been moved into the Skia repo: https://skia.googlesource.com/skia/+/master/infra/bots/recipes/
4 years, 3 months ago (2016-08-27 17:18:42 UTC) #12
Ryan Tseng
Should I delete these files from this repo then?
4 years, 3 months ago (2016-08-29 19:55:48 UTC) #13
borenet
On 2016/08/29 19:55:48, Ryan Tseng wrote: > Should I delete these files from this repo ...
4 years, 3 months ago (2016-08-30 11:21:08 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2284973002/20001
4 years, 3 months ago (2016-08-31 17:24:18 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 17:28:34 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/be52565c2553c03b801f...

Powered by Google App Engine
This is Rietveld 408576698