Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Unified Diff: components/offline_pages/offline_page_model_impl.h

Issue 2284933002: Remove OfflineURL from offline page (Closed)
Patch Set: Fix trybot Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/offline_page_model_impl.h
diff --git a/components/offline_pages/offline_page_model_impl.h b/components/offline_pages/offline_page_model_impl.h
index 566eb3df9df123104fff83025c9c00929dd8051e..8550c05258b5775cc5b5804b31bcf7ebac63dd6c 100644
--- a/components/offline_pages/offline_page_model_impl.h
+++ b/components/offline_pages/offline_page_model_impl.h
@@ -96,11 +96,6 @@ class OfflinePageModelImpl : public OfflinePageModel, public KeyedService {
const SingleOfflinePageItemCallback& callback) override;
const OfflinePageItem* MaybeGetPageByOfflineId(
int64_t offline_id) const override;
- void GetPageByOfflineURL(
- const GURL& offline_url,
- const SingleOfflinePageItemCallback& callback) override;
- const OfflinePageItem* MaybeGetPageByOfflineURL(
- const GURL& offline_url) const override;
void GetPagesByOnlineURL(
const GURL& online_url,
const MultipleOfflinePageItemCallback& callback) override;
@@ -152,11 +147,8 @@ class OfflinePageModelImpl : public OfflinePageModel, public KeyedService {
int64_t offline_id,
const SingleOfflinePageItemCallback& callback) const;
void GetPagesByOnlineURLWhenLoadDone(
- const GURL& offline_url,
+ const GURL& online_url,
const MultipleOfflinePageItemCallback& callback) const;
- void GetPageByOfflineURLWhenLoadDone(
- const GURL& offline_url,
- const SingleOfflinePageItemCallback& callback) const;
void MarkPageAccessedWhenLoadDone(int64_t offline_id);
void CheckMetadataConsistencyWhenLoadDone();

Powered by Google App Engine
This is Rietveld 408576698