Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Unified Diff: components/offline_pages/downloads/download_ui_adapter.cc

Issue 2284933002: Remove OfflineURL from offline page (Closed)
Patch Set: Fix trybot Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/downloads/download_ui_adapter.cc
diff --git a/components/offline_pages/downloads/download_ui_adapter.cc b/components/offline_pages/downloads/download_ui_adapter.cc
index b38cc591fd391634e3008faae1b90b1b9d5b424e..d9d85b3fc37119a681b746fdcae78fdba6d471ec 100644
--- a/components/offline_pages/downloads/download_ui_adapter.cc
+++ b/components/offline_pages/downloads/download_ui_adapter.cc
@@ -21,8 +21,7 @@ const char kDownloadUIAdapterKey[] = "download-ui-adapter";
DownloadUIAdapter::ItemInfo::ItemInfo(const OfflinePageItem& page)
: ui_item(base::MakeUnique<DownloadUIItem>(page)),
- offline_id(page.offline_id),
- offline_url(page.GetOfflineURL()) {}
+ offline_id(page.offline_id) {}
DownloadUIAdapter::ItemInfo::~ItemInfo() {}
@@ -130,16 +129,6 @@ void DownloadUIAdapter::DeleteItem(const std::string& guid) {
weak_ptr_factory_.GetWeakPtr()));
}
-GURL DownloadUIAdapter::GetOfflineUrlByGuid(
- const std::string& guid) const {
- // TODO(dimich): when requests are also in the cache, filter them out.
- // Requests do not yet have offline URL.
- DownloadUIItems::const_iterator it = items_.find(guid);
- if (it != items_.end())
- return it->second->offline_url;
- return GURL();
-}
-
// Note that several LoadCache calls may be issued before the async GetAllPages
// comes back.
void DownloadUIAdapter::LoadCache() {

Powered by Google App Engine
This is Rietveld 408576698