Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Unified Diff: components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc

Issue 2284933002: Remove OfflineURL from offline page (Closed)
Patch Set: Fix trybot Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc
diff --git a/components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc b/components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc
index 79675d4062de68b7ae7b3e11eb01370ebea09b5c..15a209b29831abecc585d2bdd6d7bcb182301a1e 100644
--- a/components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc
+++ b/components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc
@@ -300,12 +300,11 @@ void OfflinePageSuggestionsProvider::NotifyStatusChanged(
ContentSuggestion OfflinePageSuggestionsProvider::ConvertOfflinePage(
Category category,
const OfflinePageItem& offline_page) const {
- // TODO(pke): Make sure the URL is actually opened as an offline URL.
- // Currently, the browser opens the offline URL and then immediately
- // redirects to the online URL if the device is online.
+ // TODO(pke/jianli): Hook up to always load offline page regardless the
+ // network conditions.
ContentSuggestion suggestion(
MakeUniqueID(category, base::IntToString(offline_page.offline_id)),
- offline_page.GetOfflineURL());
+ offline_page.url);
if (offline_page.title.empty()) {
// TODO(pke): Remove this fallback once the OfflinePageModel provides titles

Powered by Google App Engine
This is Rietveld 408576698